Skip to content

[FIX] openUserInfo not working after changing room types #24098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dougfabris merged 14 commits into from
Jan 20, 2022
Merged

[FIX] openUserInfo not working after changing room types #24098

dougfabris merged 14 commits into from
Jan 20, 2022

Conversation

@grahhnt
Copy link
Contributor

@grahhnt grahhnt commented Jan 4, 2022 •
edited by dougfabris
Loading

Proposed changes (including videos or screenshots)

Change useCallback to useMutableCallback to allow for room.t updates

Issue(s)

Closes #24079
Closes #22330
Closes #23096

Steps to test or reproduce

Further comments

@grahhnt grahhnt mentioned this pull request Jan 4, 2022
Closed
@lgtm-com
Copy link

lgtm-com bot commented Jan 4, 2022

This pull request introduces 1 alert when merging 4eb3b20 into 38ebb4a - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@grahhnt grahhnt changed the title [FIX] Fix openUserInfo from not working all the time [FIX] openUserInfo not working after changing room types (#24079, #22330) Jan 6, 2022
@grahhnt grahhnt changed the title [FIX] openUserInfo not working after changing room types (#24079, #22330) [FIX] openUserInfo not working after changing room types Jan 6, 2022
@grahhnt grahhnt mentioned this pull request Jan 9, 2022
Closed
@dougfabris dougfabris mentioned this pull request Jan 10, 2022
Closed
6 tasks
@dougfabris dougfabris added this to the 4.4.0 milestone Jan 10, 2022
@dougfabris dougfabris merged commit fc286b4 into RocketChat:develop Jan 20, 2022
@grahhnt grahhnt deleted the patch-2 branch January 20, 2022 20:13
@dougfabris dougfabris linked an issue Jan 26, 2022 that may be closed by this pull request
See full profile from user card not working after navigation to a different type of room #21846
Closed
This was referenced Jan 26, 2022
Closed
Closed
@sampaiodiego sampaiodiego mentioned this pull request Jan 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dougfabris dougfabris dougfabris approved these changes

Assignees

No one assigned

Labels

communityPR

Projects

None yet

Milestone

4.4.0

2 participants

@grahhnt @dougfabris