Skip to content

[FIX] Message Erasure Type "Keep" Messages not working #24024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
murtaza98 merged 7 commits into from
Dec 30, 2021
Merged

[FIX] Message Erasure Type "Keep" Messages not working #24024

murtaza98 merged 7 commits into from
Dec 30, 2021

Conversation

@arshzip
Copy link
Contributor

@arshzip arshzip commented Dec 25, 2021 •
edited by murtaza98
Loading

Proposed changes

Check thread on #23896

Issue(s)

Fixes #23896

murtaza98
murtaza98 suggested changes Dec 27, 2021
View reviewed changes
Copy link
Contributor

@murtaza98 murtaza98 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @arshxyz I feel the first approach you mentioned here looks more elegant since there is no need to send a broadcast in case the event is not valid. I'd recommend using that solution instead. Thanks!!

@arshzip
Copy link
Contributor Author

arshzip commented Dec 29, 2021

I've made the changes accordingly, thanks

murtaza98
murtaza98 reviewed Dec 30, 2021
View reviewed changes
murtaza98
murtaza98 reviewed Dec 30, 2021
View reviewed changes
@murtaza98 murtaza98 self-requested a review December 30, 2021 13:09
@murtaza98 murtaza98 changed the title [FIX] for keeping messages when Message Erasure Type is set to 'Keep' [FIX] Message Erasure Type "Keep" Messages not working Dec 30, 2021
@murtaza98 murtaza98 merged commit 870b897 into RocketChat:develop Dec 30, 2021
@arshzip arshzip deleted the fix-keep-messages-23896 branch January 3, 2022 15:33
@sampaiodiego sampaiodiego mentioned this pull request Jan 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@murtaza98 murtaza98 murtaza98 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

communityPR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[bug] Message Erasure Type Keep Messages And User Name not work as expected

3 participants

@arshzip @murtaza98 @dudanogueira