Chore: Prettier for us all #24000
Merged
Chore: Prettier for us all #24000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request fixes 7 alerts when merging 6685403 into abf453f - view on LGTM.com fixed alerts:
|
6685403 to
14767fb
Compare
14767fb to
1ad3a2e
Compare
|
This pull request fixes 7 alerts when merging 1ad3a2e into e0f7965 - view on LGTM.com fixed alerts:
|
d-gubert
approved these changes
Dec 29, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
I've moved the file
.prettierrcthat was previously only being applied to/clientfolder.In order to make prettier and eslint to run smoothly, I had to remove few eslint rules applied to TS files.
When reviewing this PR I recommend looking the individual commits. The majority of the changes were done via
eslint --fix.Why having Prettier and ESLint together https://prettier.io/docs/en/comparison.html
Issue(s)
Closes #23792
Steps to test or reproduce
Further comments