-
Notifications
You must be signed in to change notification settings - Fork 13k
[NEW] App empty states component, category filter and empty states error variation implementations #23818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ket.Chat into feat/apps-category-filter
I've Created a new hook(useTagList) and a new component(TagList) to implement the chip list based on the selected filter categories list.
…Chat/Rocket.Chat into feat/apps-category-filter
…ket.Chat into feat/apps-category-filter
…ket.Chat into feat/apps-category-filter
Merging with origin to solve migration error
87e660b to
2423082
Compare
…into app-fallback-imp
We solved the bug where both installed and marketplace would show an error even though only the marketplace apps request failed. Also refactored some code so that it works better with our solution. Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com>
ggazzo
reviewed
Jan 19, 2022
ggazzo
reviewed
Jan 19, 2022
ggazzo
reviewed
Jan 19, 2022
ggazzo
reviewed
Jan 19, 2022
ujorgeleite
reviewed
Jan 20, 2022
ujorgeleite
suggested changes
Jan 20, 2022
ujorgeleite
approved these changes
Jan 20, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Created and implemented the category filters component:

Demo gif:
Created and implemented the empty states(States on fuselage) component:

Demo gif:
Implemented a variations system for the empty states component and created a error message for network outage:

Demo gif:
Issue(s)
Steps to test or reproduce
Further comments