Release 4.0.4 #23532
Merged
Release 4.0.4 #23532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Error handling on queue processing * add error handling to queue execution and lock timeout * add error handling to queue execution and lock timeout
* Remove roles update on insertOrUpdateSAMLUser * Check SAML Role Sync setting before updating users' roles * Add rolesSync variable * Add role sync event * Remove isEnterprise check * New code * Updated unit test for the new behavior Co-authored-by: Pierre Lehnen <pierre.lehnen@rocket.chat>
ggazzo
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2021-10-21 · 2 🐛 · 3 👩💻👨💻Engine versions
12.22.16.14.13.6, 4.0, 4.2, 4.4, 5.01.28.0🐛 Bug fixes
Queue error handling and unlocking behavior (#23522)
SAML Users' roles being reset to default on login (#23411)
Remove
rolesfield update oninsertOrUpdateSAMLUserfunction;Add SAML
syncRolesevent;👩💻👨💻 Core Team 🤓