Skip to content

Chore: Apply generics to infer types of useForm hook #22400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tassoevan merged 4 commits into from
Jan 6, 2022
Merged

Chore: Apply generics to infer types of useForm hook #22400

tassoevan merged 4 commits into from
Jan 6, 2022

Conversation

@tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Jun 18, 2021

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@tassoevan tassoevan requested a review from a team June 18, 2021 00:11
@tassoevan tassoevan changed the title Refactor: Apply generics to infer types of useForm hook Chore: Apply generics to infer types of useForm hook Jun 18, 2021
@tassoevan
Copy link
Contributor Author

tassoevan commented Jun 18, 2021 •
edited
Loading

@sampaiodiego "Chore" is not the appropriate type here 😬
Gonna link Angular standard for reference: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit

@sampaiodiego
Copy link
Member

sampaiodiego commented Jun 18, 2021

@sampaiodiego "Chore" is not the appropriate type here
Gonna link Angular standard for reference: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit

well, they don't have chore at all.. btw, very good contributing guide..

in our case, "chore" is everything that doesn't change any aspect of the product.. does it make sense? we should have it written down btw

@CLAassistant
Copy link

CLAassistant commented Dec 17, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@tassoevan tassoevan requested a review from a team January 6, 2022 13:25
@ggazzo ggazzo self-assigned this Jan 6, 2022
@tassoevan tassoevan merged commit 20b6116 into develop Jan 6, 2022
@tassoevan tassoevan deleted the refactor/use-form-types branch January 6, 2022 15:24
@sampaiodiego sampaiodiego mentioned this pull request Jan 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees

@ggazzo ggazzo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tassoevan @sampaiodiego @CLAassistant @ggazzo