[FEATURE] Omnichannel / Directory - Contacts Tab by rafaelblink · Pull Request #19904 · RocketChat/Rocket.Chat

rafaelblink · 2020-12-19T01:52:45Z

Proposed changes

Adding the contacts tab to omnichannel directory.

Issue(s)

How to test or reproduce

Screenshots

Types of changes

Bugfix (non-breaking change which fixes an issue)
Improvement (non-breaking change which improves a current function)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Hotfix (a major bugfix that has to be merged asap)
Documentation Update (if none of the other choices apply)

Checklist

I have read the CONTRIBUTING doc
I have signed the CLA
Lint and unit tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works (if applicable)
I have added necessary documentation (if applicable)
Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

…nnel Directory"

…nd new button aside filter

…cts-endpoints

…nel/directory-new-contact

…ectory-contacts

…tory button and fixing contact manager field.

lgtm-com · 2020-12-19T02:11:11Z

This pull request introduces 1 alert when merging 586386b into f8916f8 - view on LGTM.com

new alerts:

1 for Useless conditional

lgtm-com · 2020-12-21T17:51:44Z

This pull request introduces 1 alert when merging 08c9ba5 into f8916f8 - view on LGTM.com

new alerts:

1 for Useless conditional

renatobecker · 2020-12-21T18:25:45Z


-export default function CustomFieldsForm({ customFieldsData, setCustomFieldsData, onLoadFields = () => {}, ...props }) {
-	const customFieldsJson = useSetting('Accounts_CustomFields');
+export default function CustomFieldsForm({ jsonCustomFields, customFieldsData, setCustomFieldsData, onLoadFields = () => {}, ...props }) {


Let's create a new form to deal with Contact Custom Fields. Using a global form for different things may bring
coupling problems.

…, renaming contactManager data.

lgtm-com · 2020-12-21T23:30:26Z

This pull request introduces 1 alert when merging 2f5e021 into 0241ac5 - view on LGTM.com

new alerts:

1 for Useless conditional

lgtm-com · 2020-12-22T00:07:07Z

This pull request introduces 1 alert when merging 2a369dd into 0241ac5 - view on LGTM.com

new alerts:

1 for Useless conditional

lgtm-com · 2020-12-22T00:37:02Z

This pull request introduces 1 alert when merging 9943111 into 0241ac5 - view on LGTM.com

new alerts:

1 for Useless conditional

lgtm-com · 2020-12-22T01:09:26Z

This pull request introduces 1 alert when merging e5f495d into 0241ac5 - view on LGTM.com

new alerts:

1 for Useless conditional

lgtm-com · 2020-12-22T02:43:39Z

This pull request introduces 1 alert when merging 57d14e5 into 0241ac5 - view on LGTM.com

new alerts:

1 for Useless conditional

…ocketChat/Rocket.Chat into omnichannel/directory-contacts

lgtm-com · 2020-12-22T03:01:56Z

This pull request introduces 1 alert when merging 4608f20 into 0241ac5 - view on LGTM.com

new alerts:

1 for Useless conditional

rafaelblink added 28 commits November 17, 2020 12:52

[FEATURE] Directory page starting contacts/visitors tab.

6248276

[IMPROVE] Removing unused variable.

1e6dc60

Merge branch 'develop' into omnichannel/directory-page

a2cae59

[IMPROVE] Directory link tooltip to just "Directory" instead "Omnicha…

69f0e7e

…nnel Directory"

Implementing improves in contact tab, routes, last chat column mock a…

4535ba8

…nd new button aside filter

Merge branch 'develop' into omnichannel/directory-contacts

f691663

Contextual bar and routes for info and new contacts

0673f96

Merge branch 'omnichannel/directory' into omnichannel/directory-conta…

a99ec6b

…cts-endpoints

Contact endpoints for omnichannel directory forms.

58e3c5b

Merge branch 'omnichannel/directory' into omnichannel/directory-contacts

c8df323

"Last Chat" missing translation

98b5109

Merge branch 'omnichannel/directory-contacts-endpoints' into omnichan…

05d031d

…nel/directory-new-contact

Omnichannel Directory - Create new contact form.

7046d09

Merge branch 'omnichannel/directory-new-contact' into omnichannel/dir…

0cb393d

…ectory-contacts

view a specific contact and improves at contact form.

f3990ab

"edit" contact form with same "create" component

1fff342

Show custom fields in Contact Info page.

ac51957

handling custom fields on edit/create contacts.

6b5c88f

Showing only "custom fields" that are visible and with "visitor" scope.

a7fd207

CreatedAt data in Contact/Visitor and ContactInfo.

14e05ef

Add LastChat data in Contact/Visitor.

473a3f2

Show LastChat in Contact Info page and Grid

ce9c58f

Email validation improvement and asterisk on required field

2d4346b

Starting "contact manager" on edit/create page.

971c240

show contact manager user info

44e8a5e

closing contextbar when you click at cancel button, removing chat his…

5f15482

…tory button and fixing contact manager field.

Merge branch 'develop' into omnichannel/directory-contacts

c9c4663

Change useEndpointDataExperimental to useEndpointData.

ae5e5d6

rafaelblink added the planned Planned feature being handled by internal backlog label Dec 19, 2020

rafaelblink added this to the 3.10.0 milestone Dec 19, 2020

rafaelblink requested a review from renatobecker December 19, 2020 01:54

rafaelblink marked this pull request as ready for review December 19, 2020 01:54

Custom fields required with asterisk.

586386b

just using the LivechatVisitors.findOneById method

08c9ba5

renatobecker requested changes Dec 21, 2020

View reviewed changes

rafaelblink added 5 commits December 21, 2020 17:10

changing POST method to use existing method to save visitors/contacts…

200f39b

…, renaming contactManager data.

PUT not accepted so we'll use POST to save and update contacts.

4294cff

Set last chat when create a new room.

b3ba1cd

Changing place of updateLastChat method.

cca69d4

Using correct translation aliases.

2f5e021

Contact Manager Info to EE folder and renaming ContactForm.

2a369dd

Moving EE contact manager input to proper path.

9943111

rafaelblink added 2 commits December 21, 2020 21:49

verify if user has authorization to see contacts page.

b70700e

Fixing blank return useless.

e5f495d

using callback to lastChat

57d14e5

renatobecker added 2 commits December 21, 2020 23:44

Add small improvements to the code.

8a65df2

Merge branch 'omnichannel/directory-contacts' of https://github.com/R…

4608f20

…ocketChat/Rocket.Chat into omnichannel/directory-contacts

renatobecker approved these changes Dec 22, 2020

View reviewed changes

renatobecker merged commit 27d990d into omnichannel/directory Dec 22, 2020

renatobecker deleted the omnichannel/directory-contacts branch December 22, 2020 02:53

renatobecker removed this from the 3.10.0 milestone Dec 22, 2020

Conversation

rafaelblink commented Dec 19, 2020

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

Checklist

Changelog

Further comments

Uh oh!

lgtm-com Bot commented Dec 19, 2020

Uh oh!

lgtm-com Bot commented Dec 21, 2020

Uh oh!

Uh oh!

Uh oh!

renatobecker Dec 21, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lgtm-com Bot commented Dec 21, 2020

Uh oh!

lgtm-com Bot commented Dec 22, 2020

Uh oh!

lgtm-com Bot commented Dec 22, 2020

Uh oh!

lgtm-com Bot commented Dec 22, 2020

Uh oh!

lgtm-com Bot commented Dec 22, 2020

Uh oh!

lgtm-com Bot commented Dec 22, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants