Skip to content

[FIX] Message attachment's fields with different sizes #11342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ggazzo merged 1 commit into from
Jul 5, 2018
Merged

[FIX] Message attachment's fields with different sizes #11342

ggazzo merged 1 commit into from
Jul 5, 2018

Conversation

@sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Jul 4, 2018 •
edited
Loading

Before:
image

After:
image

Msg schema:

{
  "_id": "bQggkDyau77q9obZX",
  "msg": "",
  "attachments": [
    {
      "fields": [
        {
          "title": "Small field",
          "value": "one line",
          "short": true
        },
        {
          "title": "Big field",
          "value": "multiple\nlines\nsee?",
          "short": true
        }
      ]
    }
  ],
  "bot": {
    "i": "EivbwgSN3eqWkENFw"
  },
  "groupable": false,
  "emoji": ":bug:",
  "ts": "2018-07-04T16:55:04.361Z",
  "u": {
    "_id": "rocket.cat",
    "username": "rocket.cat",
    "name": "Rocket.Cat"
  },
  "rid": "GENERAL",
  "_updatedAt": "2018-07-04T16:55:04.367Z"
}

vynmera
vynmera approved these changes Jul 4, 2018
View reviewed changes
Copy link
Contributor

@vynmera vynmera left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed this a while ago, actually. Good to see it fixed :)

@ggazzo ggazzo added the ui/ux label Jul 5, 2018
@ggazzo ggazzo added this to the 0.67.0 milestone Jul 5, 2018
@ggazzo ggazzo merged commit b4e9a2e into develop Jul 5, 2018
@ggazzo ggazzo deleted the fix-attachment-fields-with-different-sizes branch July 5, 2018 18:51
@theorenck theorenck modified the milestones: 0.67.0, 0.68.0 Jul 19, 2018
@sampaiodiego sampaiodiego mentioned this pull request Jul 20, 2018
Merged
pandada8
pandada8 reviewed Aug 10, 2018
View reviewed changes
packages/rocketchat-message-attachments/client/stylesheets/messageAttachments.css
}

& .attachment-fields {
display: flex;
Copy link
Contributor

@pandada8 pandada8 Aug 10, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes all not-short (long?) fields wrap in same row.

Copy link
Member Author

@sampaiodiego sampaiodiego Aug 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it does 😞

@ggazzo will fix this

This was referenced Aug 10, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tassoevan tassoevan Awaiting requested review from tassoevan

@ggazzo ggazzo Awaiting requested review from ggazzo

3 more reviewers

@pandada8 pandada8 pandada8 left review comments

@karlprieb karlprieb karlprieb approved these changes

@vynmera vynmera vynmera approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ui/ux

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@sampaiodiego @pandada8 @karlprieb @vynmera @engelgabriel @theorenck @ggazzo