Support passing extra connection options to the Mongo driver #10529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
Author
|
I can't see anywhere obvious to document this. Any pointers? |
Contributor
|
Have a look at Rocket.Chat/docs. Best place would be somewhere under “Installing and Updating” :) |
graywolf336
previously requested changes
Apr 20, 2018
server/startup/serverRunning.js
Outdated
| } | ||
|
|
||
| var mongoOptionStr = process.env.MONGO_OPTIONS; | ||
| if (typeof(mongoOptionStr) !== 'undefined') { |
Contributor
There was a problem hiding this comment.
Let's go with typeof mongoOptionStr to stay consistent with the rest of our codebase.
sampaiodiego
requested changes
Apr 20, 2018
Member
sampaiodiego
left a comment
There was a problem hiding this comment.
looking at how Mongo.setConnectionOptions works, looks like we cannot call it multiple times.. since we're calling it already, I'll ask you to change there to merge the options received from process.env.MONGO_OPTIONS
- Remove brackets around `typeof` call for consistency with other code - Use `let` instead of `var`
…hat into mongo-connection-options
Contributor
Author
|
@sampaiodiego Done. |
Contributor
Author
|
Documentation PR at https://github.com/RocketChat/docs/pull/707 |
Contributor
Author
|
@graywolf336 / @sampaiodiego any chance you could review this today please? |
sampaiodiego
approved these changes
May 3, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10526