Skip to content

[FIX] Dropdown elements were using old styles #10482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rodrigok merged 4 commits into from
Apr 19, 2018
Merged

[FIX] Dropdown elements were using old styles #10482

rodrigok merged 4 commits into from
Apr 19, 2018

Conversation

@kaiiiiiiiii
Copy link
Contributor

@kaiiiiiiiii kaiiiiiiiii commented Apr 17, 2018 •
edited
Loading

Closes my promise to @karlprieb.

This PR changes all dropdown element types from rc-input__element to rc-select__element.

Two more things:

  1. The dropdown has still a cut off at the bottom (like any other dropdown in RC). May someone can give me a hand with that? :)
  2. Is it possible to remove the margin ("0.5rem 0") from the rc-select element? Looks a lot better without it.

Before (User UI):
screen shot 2018-04-17 at 22 17 28

After (User UI):
screen shot 2018-04-17 at 22 17 21

Before (Admin UI):
screen shot 2018-04-17 at 22 17 53

After (Admin UI):
screen shot 2018-04-17 at 22 13 43

@kaiiiiiiiii kaiiiiiiiii changed the title [FIX] Changes all dropdwon element types [FIX] Changes all dropdown element types Apr 17, 2018
@kaiiiiiiiii kaiiiiiiiii changed the title [FIX] Changes all dropdown element types [FIX] Change dropdown element types Apr 17, 2018
@graywolf336 graywolf336 requested review from ggazzo and karlprieb April 17, 2018 21:23
@karlprieb
Copy link
Contributor

karlprieb commented Apr 17, 2018

@kaiiiiiiiii can you add this arrow icon like we did on the RocketChat Apps admin panel?

Thank you! 👍

@kaiiiiiiiii
Copy link
Contributor Author

kaiiiiiiiii commented Apr 18, 2018

@karlprieb Done :)

@karlprieb
Copy link
Contributor

karlprieb commented Apr 18, 2018

Thank you @kaiiiiiiiii :)

Can you add a screenshot about the cut off at the bottom that all select elements have?

@kaiiiiiiiii
Copy link
Contributor Author

kaiiiiiiiii commented Apr 18, 2018 •
edited
Loading

100% zoom
screen shot 2018-04-18 at 21 27 34

400% zoom
screen shot 2018-04-18 at 21 28 14

1600% zoom
screen shot 2018-04-18 at 21 33 18

The UI gets a bit messy with zoom, but it's really hard to see the cut off without it.

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10482 April 18, 2018 20:10 Inactive
@karlprieb
Copy link
Contributor

karlprieb commented Apr 18, 2018

@kaiiiiiiiii you can put line-height: 1rem !important; on .rc-select__element class for now and we will find a better way to fix that in the future.

@kaiiiiiiiii
Copy link
Contributor Author

kaiiiiiiiii commented Apr 19, 2018

Done that as well, mate :)

@karlprieb karlprieb added this to the 0.64.0 milestone Apr 19, 2018
@rodrigok rodrigok changed the title [FIX] Change dropdown element types [FIX] Dropdown elements were using old styles Apr 19, 2018
@rodrigok rodrigok merged commit 76f7c73 into RocketChat:develop Apr 19, 2018
@kaiiiiiiiii kaiiiiiiiii deleted the fix_selector_element_type_for_dropdowns branch April 26, 2018 14:22
@rodrigok rodrigok mentioned this pull request Apr 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggazzo ggazzo Awaiting requested review from ggazzo

1 more reviewer

@karlprieb karlprieb karlprieb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ui/ux

Projects

None yet

Milestone

0.64.0

Development

Successfully merging this pull request may close these issues.

4 participants

@kaiiiiiiiii @karlprieb @rodrigok @engelgabriel