[FIX] REST spotlight API wasn't allowing searches with # and @ #10410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 10, 2018 15:25
Fix REST spotlight endpoint, add same logic of front to the backend, to search users and channels with # and @
graywolf336
previously requested changes
Apr 10, 2018
| }); | ||
| }); | ||
|
|
||
| describe('[/spotlight]', () => { |
Contributor
There was a problem hiding this comment.
Can we add a test that ensures the #channel works as expected? Also, actually ensure the result contains member and room objects instead of the below length that checks for 0?
I know this was just moved to the correct test file, but since we are adding a new feature to the endpoint I think it would be great to test it.
| const { query } = this.queryParams; | ||
|
|
||
| const result = Meteor.runAsUser(this.userId, () => | ||
| Meteor.call('spotlight', query, null, { |
Contributor
There was a problem hiding this comment.
Just a small change, but the { rooms: true, users: true } isn't required since that's the default... so it could just be Meteor.call('spotlight, query) 🤔
…g unused parameter
rodrigok
approved these changes
Apr 20, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix REST spotlight to allow searches with # and @.
Closes #8205.