Skip to content

[FIX] GitLab authentication scope was too open, reduced to read only access #10225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rodrigok merged 3 commits into from
Apr 17, 2018
Merged

[FIX] GitLab authentication scope was too open, reduced to read only access #10225

rodrigok merged 3 commits into from
Apr 17, 2018
+1 −1

Conversation

@rafaelks
Copy link
Contributor

@rafaelks rafaelks commented Mar 26, 2018

This change was discussed internally.

@rafaelks rafaelks requested a review from sampaiodiego March 26, 2018 21:35
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10225 March 26, 2018 21:35 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10225 March 31, 2018 21:40 Inactive
@sampaiodiego sampaiodiego added this to the 0.64.0 milestone Apr 16, 2018
@rodrigok rodrigok changed the title [FIX] Change GitLab scope from API to read_user, so we only have read access [FIX] GitLab authentication scope was too open, reduced to read only access Apr 17, 2018
@rodrigok rodrigok merged commit 2de1530 into develop Apr 17, 2018
@rodrigok rodrigok deleted the fix/request_only_read_permissions_gitlab branch April 17, 2018 17:36
@rodrigok rodrigok mentioned this pull request Apr 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.64.0

Development

Successfully merging this pull request may close these issues.

5 participants

@rafaelks @sampaiodiego @rodrigok @engelgabriel