Skip to content

[FIX] Missing "Administration" menu for user with manage-emoji permission #10171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rodrigok merged 2 commits into from
Apr 17, 2018
Merged

[FIX] Missing "Administration" menu for user with manage-emoji permission #10171

rodrigok merged 2 commits into from
Apr 17, 2018

Conversation

@c0dzilla
Copy link
Contributor

@c0dzilla c0dzilla commented Mar 19, 2018

@RocketChat/core

Closes #9865

Allows administration of custom emoji for user with manage-emoji permission.
manage-emoji-fix

@kaiiiiiiiii
Copy link
Contributor

kaiiiiiiiii commented Apr 5, 2018 •
edited
Loading

@c0dzilla

Would you mind to add some more permissions that enable the 3 dots menu to your PR?

As far as I can tell, manage-own-integrations and manage-integrations should enable the menu as well. There might be some more.

Thanks,
Kai

#10226 for reference

@c0dzilla
Copy link
Contributor Author

c0dzilla commented Apr 5, 2018

Sure @kaiiiiiiiii , I'll have a look 😄

@rodrigok rodrigok changed the title [FIX] No "Administration" option for user with manage-emoji permission [FIX] Missing "Administration" menu for user with manage-emoji permission Apr 17, 2018
@rodrigok rodrigok merged commit fe903c2 into RocketChat:develop Apr 17, 2018
@rodrigok rodrigok added this to the 0.64.0 milestone Apr 17, 2018
@kaiiiiiiiii kaiiiiiiiii mentioned this pull request Apr 22, 2018
Merged
@rodrigok rodrigok mentioned this pull request Apr 28, 2018
Merged
@kazie kazie mentioned this pull request May 29, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@karlprieb karlprieb karlprieb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.64.0

Development

Successfully merging this pull request may close these issues.

User context menu doesn't contain "Administration" anymore, nor does the "three-dots" menu

4 participants

@c0dzilla @kaiiiiiiiii @karlprieb @rodrigok