Skip to content

[BUG] The Admin Info view crash on client side in case of "tar" deployment : git metadata are missing #21794

@jdauphant

Description

@jdauphant

Description:

The Admin Info view crash on client side

Steps to reproduce:

  1. Going to admin info page /admin/info

Expected behavior:

Seeing server infos

Actual behavior:

Quick flash of view infos and the view is fastly empty.
The result :
image

Server Setup Information:

  • Version of Rocket.Chat Server: 3.13.3
  • Operating System: Scalingo
  • Deployment Method: scalingo
  • Number of Running Instances: 1
  • DB Replicaset Oplog: Enabled
  • NodeJS Version: 12.20.2
  • MongoDB Version: 4.0.3

Client Setup Information

  • Desktop App or Browser Version: Brave Version 1.17.75 Chromium: 87.0.4280.88 (Official Build) (64-bit)
  • Same error on : Firefox 87.0 (64-bit)
  • Operating System: Pop OS

Additional context

The impacted line is the code is :

{t('HEAD')}: ({s(() => commit.hash.slice(0, 9))}) <br />
(Cannot read property 'slice' of undefined)

Relevant logs:

Browser javascript console log :

ui-kit version: 0.23.0
ad19555775301fc2b49963c6b08b4ed8eb00d86e.js?meteor_js_resource=true:1411 TypeError: Cannot read property 'slice' of undefined
    at eval (/client/views/admin/info/DeploymentCard.js:1)
    at S (/client/views/admin/info/DeploymentCard.js:1)
    at e (/client/views/admin/info/DeploymentCard.js:1)
    at ma (ad19555775301fc2b49963c6b08b4ed8eb00d86e.js?meteor_js_resource=true:1411)
    at rf (ad19555775301fc2b49963c6b08b4ed8eb00d86e.js?meteor_js_resource=true:1411)
    at ef (ad19555775301fc2b49963c6b08b4ed8eb00d86e.js?meteor_js_resource=true:1411)
    at ji (ad19555775301fc2b49963c6b08b4ed8eb00d86e.js?meteor_js_resource=true:1411)
    at Hi (ad19555775301fc2b49963c6b08b4ed8eb00d86e.js?meteor_js_resource=true:1411)
    at Ui (ad19555775301fc2b49963c6b08b4ed8eb00d86e.js?meteor_js_resource=true:1411)
    at Ri (ad19555775301fc2b49963c6b08b4ed8eb00d86e.js?meteor_js_resource=true:1411)

Server logs

2021-04-25 13:35:33.760355906 +0200 CEST [web-1] Change Stream is available for your installation, give admin permissions to your database user to use this improved version.
2021-04-25 13:35:38.393376908 +0200 CEST [web-1] LocalStore: store created at
2021-04-25 13:35:38.436203884 +0200 CEST [web-1] LocalStore: store created at
2021-04-25 13:35:38.436472692 +0200 CEST [web-1] LocalStore: store created at
2021-04-25 13:35:38.801090807 +0200 CEST [web-1] Setting default file store to GridFS
2021-04-25 13:35:42.905323202 +0200 CEST [web-1] {"line":"120","file":"migrations.js","message":"Migrations: Not migrating, already at version 220","time":{"$date":1619350542904},"level":"info"}
2021-04-25 13:35:43.101850497 +0200 CEST [web-1] ufs: temp directory created at "/tmp/ufs"
2021-04-25 13:35:44.775443357 +0200 CEST [web-1] Loaded the Apps Framework and loaded a total of 0 Apps!
2021-04-25 13:35:44.850933910 +0200 CEST [web-1] Using GridFS for custom sounds storage
2021-04-25 13:35:44.852647686 +0200 CEST [web-1] Using GridFS for custom emoji storage
2021-04-25 13:35:45.049876381 +0200 CEST [web-1] Browserslist: caniuse-lite is outdated. Please run next command `npm update`
2021-04-25 13:35:45.242359386 +0200 CEST [web-1] Updating process.env.MAIL_URL
2021-04-25 13:35:45.495424519 +0200 CEST [web-1] ➔ System ➔ startup
2021-04-25 13:35:45.495766736 +0200 CEST [web-1] ➔ +----------------------------------------------------------+
2021-04-25 13:35:45.495996004 +0200 CEST [web-1] ➔ |                      SERVER RUNNING                      |
2021-04-25 13:35:45.496176156 +0200 CEST [web-1] ➔ +----------------------------------------------------------+
2021-04-25 13:35:45.496774538 +0200 CEST [web-1] ➔ |  Rocket.Chat Version: 3.13.3                             |
2021-04-25 13:35:45.496491077 +0200 CEST [web-1] ➔ |                                                          |
2021-04-25 13:35:45.497156027 +0200 CEST [web-1] ➔ |      MongoDB Version: 4.0.3                              |
2021-04-25 13:35:45.496970401 +0200 CEST [web-1] ➔ |       NodeJS Version: 12.20.2 - x64                      |
2021-04-25 13:35:45.497904757 +0200 CEST [web-1] ➔ |             Site URL: https://rocketchat.incubateur.net  |
2021-04-25 13:35:45.497781085 +0200 CEST [web-1] ➔ |         Process Port: 28537                              |
2021-04-25 13:35:45.497577177 +0200 CEST [web-1] ➔ |             Platform: linux                              |
2021-04-25 13:35:45.497380098 +0200 CEST [web-1] ➔ |       MongoDB Engine: unknown                            |
2021-04-25 13:35:45.498604338 +0200 CEST [web-1] ➔ +----------------------------------------------------------+
2021-04-25 13:35:45.498432326 +0200 CEST [web-1] ➔ |                                                          |
2021-04-25 13:35:45.498091481 +0200 CEST [web-1] ➔ |     ReplicaSet OpLog: Enabled                            |

commit.hash isn't shown :

msg.push(` Commit Hash: ${ Info.commit.hash.substr(0, 10) }`);

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions