Skip to content

Detect internal functions that are @deprecated#660

Merged
Ocramius merged 4 commits intoRoave:masterfrom
BackEndTea:fix/deprecation-check
Jul 9, 2020
Merged

Detect internal functions that are @deprecated#660
Ocramius merged 4 commits intoRoave:masterfrom
BackEndTea:fix/deprecation-check

Conversation

@BackEndTea
Copy link
Copy Markdown
Contributor

@BackEndTea BackEndTea commented Jun 11, 2020

@ondrejmirtes
Copy link
Copy Markdown
Contributor

This should probably be done as an enhancement of #603 to be really good. (We don't want to tell people running on PHP 7.1 about a deprecation on 7.4.)

Copy link
Copy Markdown
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes needed, but otherwise patcb looking good! 👍

@Ocramius Ocramius modified the milestones: 4.6.0, 4.7.0 Jun 11, 2020
@Ocramius Ocramius modified the milestones: 4.7.0, 4.8.0 Jul 6, 2020
@BackEndTea BackEndTea force-pushed the fix/deprecation-check branch from f8ca985 to 3bde95a Compare July 9, 2020 06:54
@Ocramius Ocramius self-assigned this Jul 9, 2020
@Ocramius Ocramius merged commit 52f6737 into Roave:master Jul 9, 2020
@Ocramius Ocramius changed the title Allow functions to be deprecated Detect internal functions that are @deprecated Jul 9, 2020
@Ocramius
Copy link
Copy Markdown
Member

Ocramius commented Jul 9, 2020

Thanks @BackEndTea!

@BackEndTea
Copy link
Copy Markdown
Contributor Author

Thanks @Ocramius, @ondrejmirtes & @jaapio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create ReflectionFunctions/ReflectionClasses from internal definitions

4 participants