Support indirect Stringable interface via __toString() in trait#1524
Merged
Ocramius merged 6 commits intoRoave:6.63.xfrom Sep 9, 2025
Merged
Support indirect Stringable interface via __toString() in trait#1524Ocramius merged 6 commits intoRoave:6.63.xfrom
Stringable interface via __toString() in trait#1524Ocramius merged 6 commits intoRoave:6.63.xfrom
Conversation
Ocramius
requested changes
Sep 9, 2025
Member
Ocramius
left a comment
There was a problem hiding this comment.
Patch meaningful, but the implementation (just inside the private method) needs to be refactored
src/Reflection/ReflectionClass.php
Outdated
Comment on lines
+1335
to
+1352
| foreach ($this->getTraits() as $trait) { | ||
| foreach (array_keys($trait->immediateMethods) as $immediateMethodName) { | ||
| if (strtolower($immediateMethodName) === '__tostring') { | ||
| try { | ||
| $stringableInterfaceReflection = $this->reflector->reflectClass($stringableClassName); | ||
|
|
||
| if ($stringableInterfaceReflection->isInternal()) { | ||
| $interfaces[$stringableClassName] = $stringableInterfaceReflection; | ||
| } | ||
| } catch (IdentifierNotFound) { | ||
| // Stringable interface does not exist on target PHP version | ||
| } | ||
|
|
||
| // @infection-ignore-all Break_: There's no difference between break and continue - break is just optimization | ||
| break 2; | ||
| } | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Instead of repeating this whole block, merge methods from the traits into immediate methods above?
Ocramius
approved these changes
Sep 9, 2025
Stringable interface via __toString() in trait
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
required for phpstan/phpstan#13469