Skip to content

PHP 8.4 support#1462

Merged
Ocramius merged 24 commits intoRoave:6.44.xfrom
kukulich:php84
Dec 2, 2024
Merged

PHP 8.4 support#1462
Ocramius merged 24 commits intoRoave:6.44.xfrom
kukulich:php84

Conversation

@kukulich
Copy link
Copy Markdown
Collaborator

No description provided.

@kukulich kukulich changed the title Run checks on PHP 8.4 Basic PHP 8.4 support Nov 23, 2024
@kukulich kukulich force-pushed the php84 branch 2 times, most recently from 28c8626 to fef899b Compare November 23, 2024 14:35
@kukulich kukulich changed the title Basic PHP 8.4 support PHP 8.4 support Nov 23, 2024
@kukulich kukulich force-pushed the php84 branch 5 times, most recently from 8c6722d to 02d1a4a Compare November 23, 2024 21:38
@kukulich kukulich marked this pull request as ready for review November 23, 2024 21:55
@kukulich kukulich marked this pull request as draft November 25, 2024 10:36
@kukulich kukulich force-pushed the php84 branch 5 times, most recently from 562d21b to 3e8440f Compare November 25, 2024 11:08
@kukulich kukulich marked this pull request as ready for review November 25, 2024 11:25
@kukulich kukulich force-pushed the php84 branch 2 times, most recently from 3c39cad to f3f6452 Compare November 25, 2024 22:19
@Ocramius
Copy link
Copy Markdown
Member

@kukulich I've only seen this patch from afar: do ping when you believe it should be looked at in detail (currently quite busy with work, sorry)

@Ocramius Ocramius added this to the 6.44.0 milestone Nov 26, 2024
@Ocramius Ocramius added BC break dependencies Pull requests that update a dependency file labels Nov 26, 2024
@kukulich
Copy link
Copy Markdown
Collaborator Author

@Ocramius It should be ready to review :) I hope it's full support of PHP 8.4.

@ondrejmirtes
Copy link
Copy Markdown
Contributor

FYI PHPStan is living on the edge - I rebased my fork on top of this PR and already using that in 2.0.x 😂 Might report some issues in a few days when I get the chance to test it thoroughly.

@Ocramius
Copy link
Copy Markdown
Member

Yeah, I imagined :D

I just got off work now, so I'll probably be able to review tomorrow :)

@kukulich kukulich force-pushed the php84 branch 2 times, most recently from b448eeb to 9c8e548 Compare November 28, 2024 19:17
@Ocramius
Copy link
Copy Markdown
Member

Ocramius commented Dec 2, 2024

@kukulich can you check (and eventually dismiss) the remaining open threads? Happy to ship afterwards :)

@Ocramius Ocramius removed the BC break label Dec 2, 2024
Copy link
Copy Markdown
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: stellar work as usual, @kukulich! 🚀

@Ocramius Ocramius self-assigned this Dec 2, 2024
@Ocramius Ocramius merged commit 6ff8860 into Roave:6.44.x Dec 2, 2024
@Ocramius Ocramius linked an issue Dec 2, 2024 that may be closed by this pull request
@kukulich kukulich deleted the php84 branch December 2, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file enhancement reflection compatibility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Does not work with php 8.4

3 participants