Skip to content

Added missing true type as ReflectionNamedType#isBuiltIn() value#1152

Merged
Ocramius merged 1 commit intoRoave:5.7.xfrom
staabm:true
Jul 22, 2022
Merged

Added missing true type as ReflectionNamedType#isBuiltIn() value#1152
Ocramius merged 1 commit intoRoave:5.7.xfrom
staabm:true

Conversation

@staabm
Copy link
Copy Markdown
Contributor

@staabm staabm commented Jul 22, 2022

https://wiki.php.net/rfc/true-type

inspired by 0f76eb1 I figured this might already be evertyhing required..?

@staabm staabm marked this pull request as ready for review July 22, 2022 20:25
@Ocramius Ocramius added this to the 5.7.0 milestone Jul 22, 2022
@Ocramius Ocramius self-assigned this Jul 22, 2022
Copy link
Copy Markdown
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 thanks @staabm!

@Ocramius Ocramius merged commit 40fd8e5 into Roave:5.7.x Jul 22, 2022
@Ocramius Ocramius changed the title Added missing 'true' type as ReflectionNamedType isBuiltIn() value Added missing true type as ReflectionNamedType#isBuiltIn() value Jul 22, 2022
@staabm staabm deleted the true branch July 22, 2022 20:42
@staabm
Copy link
Copy Markdown
Contributor Author

staabm commented Jul 23, 2022

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants