chore: migrate to php-standard-library version 6 and drop php 8.3#991
Merged
Ocramius merged 1 commit intoRoave:8.20.xfrom Mar 20, 2026
Merged
chore: migrate to php-standard-library version 6 and drop php 8.3#991Ocramius merged 1 commit intoRoave:8.20.xfrom
Ocramius merged 1 commit intoRoave:8.20.xfrom
Conversation
7e8b9f0 to
c5e4e98
Compare
azjezz
commented
Mar 20, 2026
Comment on lines
+184
to
188
| Async\concurrently([ | ||
| fn () => $this->git->remove($fromPath), | ||
| fn () => $this->git->remove($toPath), | ||
| ]); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
both call Shell\execute which waits, so can be called concurrently.
Comment on lines
+143
to
+146
| [$fromPath, $toPath] = Async\concurrently([ | ||
| fn () => $this->git->checkout($sourceRepo, $fromRevision), | ||
| fn () => $this->git->checkout($sourceRepo, $toRevision), | ||
| ]); |
Contributor
Author
There was a problem hiding this comment.
both call Shell\execute which waits, and do not rely on each other, can be ran concurrently.
d4ed988 to
45fbcc8
Compare
Signed-off-by: azjezz <azjezz@protonmail.com>
45fbcc8 to
540908b
Compare
Ocramius
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.