bug: protected method in final class -> private is not a BC break#986
Merged
Ocramius merged 2 commits intoRoave:8.18.xfrom Feb 9, 2026
Merged
Conversation
A final class cannot be extended, therefore `protected` and `private` are functionally identical. `protected` methods may exist in final classes for historical reasons, but making them `private` is not a BC break.
A method should only be considered "accessible" outside the class if: * It is `public` * It is `protected` and the class is NOT `final` Previously, `protected` methods in `final` classes were incorrectly considered to be accessible. This meant that changing one to `protected` would incorrectly be reported as a BC break. This commit fixes that logic.
Contributor
Author
|
I realised my "push separately" strategy doesn't work as the CI needs approval for new contributors. I figured it was therefore easier to push both commits now, but let me know if you'd like to see proof of the test failing. |
acoulton
commented
Feb 9, 2026
asgrim
approved these changes
Feb 9, 2026
Ocramius
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A method should only be considered "accessible" outside the class if:
publicprotectedand the class is NOTfinalPreviously,
protectedmethods infinalclasses were incorrectlyconsidered to be accessible. This meant that changing one to
protectedwould incorrectly be reported as a BC break.
This PR introduces two commits - one that introduces a new testcase to prove the issue, and a second with the fix. I will push separately so that CI shows the new test failing initially.