some initial Roaring64Bitmap benchmarks #797
Merged
+130
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemire
reviewed
Aug 20, 2025
| public Roaring64Bitmap addLong(BenchmarkState state) { | ||
| Roaring64Bitmap bitmap = new Roaring64Bitmap(); | ||
| for (long index : state.indexes) { | ||
| bitmap.addLong(index); |
Member
There was a problem hiding this comment.
There are alternatives worth including: Roaring64Bitmap.bitmapOf (it calls the bulked add function underneath). It should run at the same speed (just about) since we have not optimized it, but it has the potential to be optimized dramatically.
Contributor
Author
There was a problem hiding this comment.
added some more methods and patterns
Contributor
Author
There was a problem hiding this comment.
were there the ones that you wanted
Member
|
Please consider my small comment. |
lemire
approved these changes
Aug 20, 2025
Contributor
Author
|
from the command line JMH ignores the annotations that control the benchmark (time, iterations, warmups, forks) e.g. from |
Member
|
@mkeskells JMH is the de facto standard for running benchmarks in Java, but it has downsides. |
Member
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
no changes to code or unit test. Just benchmarks for addition and lookup
Automated Checks
./gradlew testand made sure that my PR does not break any unit test.