[64 bit bitmaps) Split non-leaf - BranchNode from leaf nodes (to reduce memory footprint) #786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move branch-specific methods to BranchNode replace checks for LEAF_NODE with instanceof checks make some leaf-node-specific code to conditional
0279cb2 to
04fe661
Compare
Member
|
This is reasonable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
On all nodes - remove NodeType - its hardly used anyway
Leaf nodes comprise > 50% of all Node (I believe), and there are fields that can never be used/are constant, so remove them by add a BranchNode which can have prefixes/size etc
Automated Checks
./gradlew testand made sure that my PR does not break any unit test.