Skip to content

reduce retained memory and allocations in LeafNode #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lemire merged 1 commit into from
Aug 4, 2025
Merged

reduce retained memory and allocations in LeafNode #782

lemire merged 1 commit into from
Aug 4, 2025
+53 −18

Conversation

@mkeskells
Copy link
Contributor

@mkeskells mkeskells commented Aug 1, 2025

SUMMARY

  • Describe your changes, including rationale and design decisions
  • reduce retained memory in LeafNode - make the key just 48 bits
  • dont allocate byte[] to handle keys - just manipulate the bytes

Automated Checks

@mkeskells mkeskells marked this pull request as draft August 1, 2025 08:49
@mkeskells
Copy link
Contributor Author

mkeskells commented Aug 1, 2025 •
edited
Loading

draft til I look at the failures. Nothing failed locally

@lemire
Copy link
Member

lemire commented Aug 1, 2025

@mkeskells It looks like a 32-bit/64-bit issue.

>>> hex(9223372036854775807)
'0x7fffffffffffffff'
>>> hex(140737488355327)
'0x7fffffffffff'

@mkeskells mkeskells force-pushed the remove-some-allocation-and-reduce-retained-size branch 3 times, most recently from c8e237b to 52b6a3a Compare August 3, 2025 07:40
@mkeskells mkeskells marked this pull request as ready for review August 3, 2025 07:40
@mkeskells
2 changes
bcad28f 
- reduce retained memory in LeafNode
- dont allocate byte[] to handle keys
@mkeskells mkeskells force-pushed the remove-some-allocation-and-reduce-retained-size branch from 52b6a3a to bcad28f Compare August 4, 2025 22:00
@mkeskells
Copy link
Contributor Author

mkeskells commented Aug 4, 2025

@mkeskells It looks like a 32-bit/64-bit issue.

>>> hex(9223372036854775807)
'0x7fffffffffffffff'
>>> hex(140737488355327)
'0x7fffffffffff'

Thanks - sign extension. I miss unsigned ints :-(

@lemire lemire merged commit 5090452 into RoaringBitmap:master Aug 4, 2025
7 checks passed
@lemire
Copy link
Member

lemire commented Aug 4, 2025

merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mkeskells @lemire