Fix DribbbleRipper to get image URLs#2158
Merged
soloturn merged 1 commit intoRipMeApp:mainfrom Oct 3, 2025
Merged
Conversation
* Update parsing logic for the site's new layout * Enable test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
This change is exactly one of the following (please change
[ ]to[x]) to indicate which:Description
The site changed its layout, so the original logic for parsing image URLs no longer works. This PR updates the logic to get the largest image URL from the
<img>element inside eachdiv.shot-thumbnail-base.Testing
Required verification:
gradlew test(there are no new failures or errors).Optional but recommended: