Draft
Conversation
7476abc to
b95f9d8
Compare
283cdfe to
36c6f85
Compare
b95f9d8 to
6975a77
Compare
6 tasks
|
Related: opencv#18843 |
9c38ca1 to
ae94d35
Compare
369bc7d to
476fc39
Compare
5a55be0 to
b949a72
Compare
7963e82 to
be919ae
Compare
… namespace conflict
ecb1e72 to
de74111
Compare
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing notes:
python platforms/apple/build_xcframework.py platforms/apple/xcframework-build/or place your prebuiltopencv2.xcframeworkatplatforms/apple/xcframework-build/opencv2.xcframeworkswift buildCurrently dealing with some interface issues with the existing Swift module from the
objcmodule:I think one possible solution could be to remove the Swift stuff from the objc module and only include it via the Swift Package, but it would be a breaking change for consumers of the existing module.
TODO:
modules/core/misc/objc/testto run viaswift testResolves opencv#18398