Skip to content

wayland: Don't bother to commit preedit text on deactivate#205

Merged
Riey merged 1 commit intoRiey:developfrom
simnalamburt:cannot-commit-before-deactivate
Feb 5, 2021
Merged

wayland: Don't bother to commit preedit text on deactivate#205
Riey merged 1 commit intoRiey:developfrom
simnalamburt:cannot-commit-before-deactivate

Conversation

@simnalamburt
Copy link
Copy Markdown
Contributor

@simnalamburt simnalamburt commented Feb 5, 2021

With input-method-unstable-v2, it's impossible to finish preedit texts before deactivate.

I think this is a bug in IME. Focus changes deactivates the input-method and I think there is no way to know it is going to be deactivated in advance. Which means IME does not have chance to commit string to old text-input. Also, by the protocol, there is no way to distinguish the text-input behind. With these, I think IME should reset their internal states (for example, to-be-committed string) on deactivate. This is what my wlchewing does, and so it does not have this bug.

@xdavidwu

Reference

With input-method-unstable-v2, it's impossible to finish preedit texts
before deactivate.

    I think this is a bug in IME. Focus changes deactivates the
    input-method and I think there is no way to know it is going to be
    deactivated in advance. Which means IME does not have chance to
    commit string to old text-input. Also, by the protocol, there is no
    way to distinguish the text-input behind. With these, I think IME
    should reset their internal states (for example, to-be-committed
    string) on deactivate. This is what my wlchewing does, and so it
    does not have this bug.

    @xdavidwu

Reference:
  swaywm/sway#4932 (comment)
@Riey Riey merged commit 6c38da4 into Riey:develop Feb 5, 2021
@simnalamburt simnalamburt deleted the cannot-commit-before-deactivate branch February 5, 2021 19:58
@Riey Riey mentioned this pull request Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants