Skip to content

types: add export to package.json, test with strict mode and node16 resolution#19

Merged
Rich-Harris merged 3 commits intoRich-Harris:masterfrom
ChristianMurphy:type/node-16-esm-types
Jan 25, 2023
Merged

types: add export to package.json, test with strict mode and node16 resolution#19
Rich-Harris merged 3 commits intoRich-Harris:masterfrom
ChristianMurphy:type/node-16-esm-types

Conversation

@ChristianMurphy
Copy link
Copy Markdown
Contributor

@ChristianMurphy ChristianMurphy commented Jan 3, 2023 •
edited
Loading

hold off on merging this for a bit, it may require a change to is-reference first

updates upstream PRs have been merged.

This PR

  • adds type exports to package.json
  • runs typescript in strict mode
  • resolves modules in typescript in node16 (esm) mode
  • moves @types/estree to dependencies for typescript users
  • updates @types/estree to version 1.x
  • test compatibility with acorn version 8

@ChristianMurphy
Copy link
Copy Markdown
Contributor Author

ChristianMurphy commented Jan 3, 2023

opened Rich-Harris/is-reference#14 for is-reference update

@ChristianMurphy ChristianMurphy mentioned this pull request Jan 3, 2023
Closed
@ChristianMurphy
Copy link
Copy Markdown
Contributor Author

ChristianMurphy commented Jan 3, 2023

This may also require an update to estree-walker, WIP PR started here: Rich-Harris/estree-walker#34

@ChristianMurphy ChristianMurphy mentioned this pull request Jan 16, 2023
Merged
@ChristianMurphy
Copy link
Copy Markdown
Contributor Author

ChristianMurphy commented Jan 20, 2023

Upstream PRs have been merged.
Tests and type checks are passing.

This is ready for review when folks have a moment.
/cc @Rich-Harris @wooorm @remcohaszing

@ChristianMurphy
Copy link
Copy Markdown
Contributor Author

ChristianMurphy commented Jan 25, 2023

@Rich-Harris friendly ping.
Anything I could do to help get this across the finish line?

@Rich-Harris Rich-Harris merged commit 14eb54c into Rich-Harris:master Jan 25, 2023
@ChristianMurphy ChristianMurphy deleted the type/node-16-esm-types branch January 25, 2023 19:43
@Rich-Harris
Copy link
Copy Markdown
Owner

Rich-Harris commented Jan 25, 2023

done, thank you! released 3.1.0

@ChristianMurphy
Copy link
Copy Markdown
Contributor Author

ChristianMurphy commented Jan 25, 2023

Thanks @Rich-Harris! 🙇

@ChristianMurphy
Copy link
Copy Markdown
Contributor Author

ChristianMurphy commented Jan 25, 2023 •
edited
Loading

@Rich-Harris quick question while this is top of mind, was this pushed to npmjs.com?
I'm checking

npm view periscopic

and it is still listing version 3.0.4 as the latest version

@ChristianMurphy
Copy link
Copy Markdown
Contributor Author

ChristianMurphy commented Jan 26, 2023

I think something went wrong with the release, npm is still showing 3.0.4 as latest today, no 3.1.0 is appearing yet.

@Rich-Harris
Copy link
Copy Markdown
Owner

Rich-Harris commented Jan 26, 2023

that's weird, could have sworn it went through. looks to be fixed now

@ChristianMurphy
Copy link
Copy Markdown
Contributor Author

ChristianMurphy commented Jan 26, 2023

Thanks, I can see the new version now 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@remcohaszing remcohaszing remcohaszing approved these changes

@wooorm wooorm wooorm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ChristianMurphy @Rich-Harris @remcohaszing @wooorm