Skip to content

fix(security): resolve remaining oxlint findings#410

Merged
YogliB merged 5 commits into
masterfrom
feature/oxlint-security-plugin
May 20, 2026
Merged

fix(security): resolve remaining oxlint findings#410
YogliB merged 5 commits into
masterfrom
feature/oxlint-security-plugin

Conversation

@YogliB

@YogliB YogliB commented May 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fix the remaining real security findings in src/, suppress the intentional false positives with narrow inline comments, and keep the broad test/** security override so test-only filesystem and mock patterns stay quiet.

Changes

  • Replaced the shell-based command wrapper in src/utils.js with execFile-based execution.
  • Simplified repository parsing in src/index.js to remove the unsafe regex while preserving supported URL forms.
  • Restored directive loading and cache behavior in src/index.js after the parser cleanup.
  • Added narrow security-rule suppressions for the remaining false positives in src/index.js, src/bin.js, and src/utils.js.
  • Kept the test/** security override in .oxlintrc.json and updated test helpers to match the new command-execution shape.

Acknowledgments

Testing

How you verified this (commands, scenarios, or N/A):

  • Automated tests (bun run test)
  • Manual / CLI check if user-facing behavior changed
  • CI passes

Review notes

Breaking changes: none

Risks / rollout: The parser and command wrapper changes were validated with the focused test files and the full suite. The remaining lint suppressions are intentionally narrow and limited to known false positives.

Focus areas for reviewers: src/index.js parser and directive handling, src/utils.js command wrapper, and the test/** lint override in .oxlintrc.json.

Checklist

  • Error paths and exit codes considered where relevant
  • Help text, completions, or docs updated if user-facing strings changed
  • Squashed to a single commit
  • No unrelated drive-by changes

@YogliB YogliB changed the title feat(lint): add oxlint security plugin fix(lint): silence false positives May 20, 2026
@YogliB YogliB changed the title fix(lint): silence false positives fix(security): resolve remaining oxlint findings May 20, 2026
@YogliB YogliB merged commit 4ac99e4 into master May 20, 2026
7 checks passed
@YogliB YogliB deleted the feature/oxlint-security-plugin branch May 20, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant