fix(security): resolve remaining oxlint findings#410
Merged
Conversation
This was referenced May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the remaining real security findings in
src/, suppress the intentional false positives with narrow inline comments, and keep the broadtest/**security override so test-only filesystem and mock patterns stay quiet.Changes
src/utils.jswithexecFile-based execution.src/index.jsto remove the unsafe regex while preserving supported URL forms.src/index.jsafter the parser cleanup.src/index.js,src/bin.js, andsrc/utils.js.test/**security override in.oxlintrc.jsonand updated test helpers to match the new command-execution shape.Acknowledgments
Testing
How you verified this (commands, scenarios, or N/A):
bun run test)Review notes
Breaking changes: none
Risks / rollout: The parser and command wrapper changes were validated with the focused test files and the full suite. The remaining lint suppressions are intentionally narrow and limited to known false positives.
Focus areas for reviewers:
src/index.jsparser and directive handling,src/utils.jscommand wrapper, and thetest/**lint override in.oxlintrc.json.Checklist