Skip to content

Switch from deprecated arma::is_finite to std::isfinite#28

Merged
ManosPapadakis95 merged 4 commits intoRfastOfficial:Devfrom
eddelbuettel:master
Oct 6, 2025
Merged

Switch from deprecated arma::is_finite to std::isfinite#28
ManosPapadakis95 merged 4 commits intoRfastOfficial:Devfrom
eddelbuettel:master

Conversation

@eddelbuettel
Copy link

@eddelbuettel eddelbuettel commented Sep 22, 2025

Armadillo 15.0.* now makes C++14 the minimum compilation standard, which also means I can no-longer add the suppression of deprecation warnings (which used a macro before and now use a C++14 or later attribute). For most packages, adapting to it can be very simple, and yours is one of them -- in fact it is in just three files. In the patch below we simply update this as now required by Armadillo 15.0.x.

Please see issues #475 and below at the RcppArmadillo GitHub repo for context, and notably #491 for this second wave of PRs and patches (following one for moving away from C++11, something your package does not need). It would be terrific if you could make an upload to CRAN 'soon' to remove the deprecation warning. Please do not hesitate to reach out if I can assist in any way or clarify matters.

ManosPapadakis95 and others added 4 commits March 11, 2024 21:16
@ManosPapadakis95
Squashed commit of the following:
645fdad 
commit 98a082c
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Mon Mar 11 21:15:53 2024 +0200

    fix bugs

commit a4a3cf5
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Mon Mar 11 21:15:33 2024 +0200

    Update parallel.h

commit 10e9240
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Mon Mar 11 21:15:27 2024 +0200

    Update DESCRIPTION

commit fde4fb1
Author: Michail Tsagris <mtsagris@yahoo.gr>
Date:   Wed Mar 6 19:51:38 2024 +0200

    change

commit 2afc14d
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Wed Mar 6 13:39:48 2024 +0200

    fix some bugs

commit 0460527
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Fri Feb 23 23:15:11 2024 +0200

    replace old NULL with nullptr

commit 725cc4c
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Fri Feb 23 23:14:51 2024 +0200

    Update collognorm.mle.Rd

commit 10e4b50
Author: Michail Tsagris <mtsagris@yahoo.gr>
Date:   Fri Feb 23 23:06:09 2024 +0200

    change

commit fd4cb89
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Tue Feb 20 22:09:15 2024 +0200

    fix bug

commit 20774ab
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Tue Feb 20 22:05:34 2024 +0200

    Merge branch 'Dev' of https://github.com/RfastOfficial/Rfast2 into Dev

commit abe9893
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Tue Feb 20 22:03:06 2024 +0200

    Revert "Merge branch 'Dev' of https://github.com/RfastOfficial/Rfast2 into Dev"

    This reverts commit 7314ccd, reversing
    changes made to 014ec2b.

commit 7314ccd
Merge: 014ec2b 6aadbe7
Author: Michail Tsagris <mtsagris@yahoo.gr>
Date:   Tue Feb 20 20:55:07 2024 +0200

    Merge branch 'Dev' of https://github.com/RfastOfficial/Rfast2 into Dev

commit 014ec2b
Author: Michail Tsagris <mtsagris@yahoo.gr>
Date:   Tue Feb 20 20:55:03 2024 +0200

    change

commit 6aadbe7
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Tue Feb 20 19:38:50 2024 +0200

    Revert "add warnings"

    This reverts commit f4190e9.

commit f7e527d
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Wed Feb 14 15:26:55 2024 +0200

    fix bug

commit 5a83d54
Author: Michail Tsagris <mtsagris@yahoo.gr>
Date:   Tue Feb 6 12:11:11 2024 +0200

    change

commit ad51bc9
Author: Michail Tsagris <mtsagris@yahoo.gr>
Date:   Sun Feb 4 19:25:27 2024 +0200

    change

commit 4324a3a
Merge: 3f21641 f4190e9
Author: Michail Tsagris <mtsagris@yahoo.gr>
Date:   Wed Jan 24 17:02:42 2024 +0200

    Merge branch 'Dev' of https://github.com/RfastOfficial/Rfast2 into Dev

commit 3f21641
Author: Michail Tsagris <mtsagris@yahoo.gr>
Date:   Wed Jan 24 17:02:16 2024 +0200

    change

commit f4190e9
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Fri Jan 19 19:12:27 2024 +0200

    add warnings

commit 2469010
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Fri Jan 19 19:12:34 2024 +0200

    Update NEWS.md

commit 0ee990f
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Fri Jan 19 19:12:30 2024 +0200

    Update DESCRIPTION

commit 4ccb97e
Author: Michail Tsagris <mtsagris@yahoo.gr>
Date:   Thu Dec 7 14:28:10 2023 +0200

    change

commit d547c07
Author: Michail Tsagris <mtsagris@yahoo.gr>
Date:   Thu Dec 7 14:27:29 2023 +0200

    change

commit be09c5d
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Wed Dec 6 12:54:04 2023 +0200

    Update NEWS.md

commit 2f32355
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Wed Dec 6 12:54:00 2023 +0200

    fix macros

commit b972696
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Wed Nov 15 16:40:52 2023 +0200

    Update README.md

commit 9af0cc8
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Wed Nov 15 16:40:49 2023 +0200

    Update settings.json

commit 2aec718
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Wed Nov 15 16:40:46 2023 +0200

    add new method for col group

commit 609d527
Author: Michail Tsagris <mtsagris@yahoo.gr>
Date:   Tue Nov 14 19:29:09 2023 +0200

    change

commit c41d1e6
Author: Michail Tsagris <mtsagris@yahoo.gr>
Date:   Tue Nov 14 18:54:15 2023 +0200

    change

commit 916c2af
Author: Michail Tsagris <mtsagris@yahoo.gr>
Date:   Tue Oct 31 10:45:15 2023 +0200

    change

commit cba662e
Author: Michail Tsagris <mtsagris@yahoo.gr>
Date:   Tue Oct 31 10:43:55 2023 +0200

    change

commit e091936
Author: Michail Tsagris <mtsagris@yahoo.gr>
Date:   Fri Oct 27 19:49:01 2023 +0300

    change

commit d1273d0
Author: Michail Tsagris <mtsagris@yahoo.gr>
Date:   Fri Oct 27 19:45:14 2023 +0300

    change

commit 54ffec7
Merge: b4726b8 37a4b02
Author: Michail Tsagris <mtsagris@yahoo.gr>
Date:   Fri Oct 27 19:33:54 2023 +0300

    Merge branch 'Dev' of https://github.com/RfastOfficial/Rfast2 into Dev

commit b4726b8
Author: Michail Tsagris <mtsagris@yahoo.gr>
Date:   Fri Oct 27 19:33:51 2023 +0300

    change

commit 37a4b02
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Fri Oct 27 14:05:27 2023 +0300

    fix bugs

commit 8b12f11
Author: Michail Tsagris <mtsagris@yahoo.gr>
Date:   Thu Oct 26 21:00:21 2023 +0300

    change

commit 10534f2
Author: Michail Tsagris <mtsagris@yahoo.gr>
Date:   Thu Oct 26 20:56:34 2023 +0300

    change

commit 1d35e7b
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Thu Oct 26 20:00:29 2023 +0300

    add manos work

commit 89ae346
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Thu Oct 26 20:00:11 2023 +0300

    Update normal.etest.R

commit 9d92222
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Thu Oct 26 19:59:55 2023 +0300

    Update NAMESPACE

commit a6acd3a
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Wed Oct 25 23:49:37 2023 +0300

    remove deprecated function

commit a0c8d70
Author: Michail Tsagris <mtsagris@yahoo.gr>
Date:   Tue Oct 24 21:59:50 2023 +0300

    change

commit 99b4bba
Author: Michail Tsagris <mtsagris@yahoo.gr>
Date:   Tue Oct 24 21:51:03 2023 +0300

    change

commit c23e0a3
Author: Michail Tsagris <mtsagris@yahoo.gr>
Date:   Tue Oct 17 17:15:26 2023 +0300

    change

commit 8d0b8c5
Author: Michail Tsagris <mtsagris@yahoo.gr>
Date:   Mon Oct 16 21:54:46 2023 +0300

    change

commit bffd73d
Author: Michail Tsagris <mtsagris@yahoo.gr>
Date:   Mon Oct 16 21:52:57 2023 +0300

    change

commit fbf870a
Author: Michail Tsagris <mtsagris@yahoo.gr>
Date:   Mon Oct 16 21:52:11 2023 +0300

    change

commit 6a32640
Author: Michail Tsagris <mtsagris@yahoo.gr>
Date:   Mon Oct 16 21:50:55 2023 +0300

    change

commit 6106725
Author: Michail Tsagris <mtsagris@yahoo.gr>
Date:   Fri Sep 29 16:44:09 2023 +0300

    change

commit 56b4fc0
Author: Michail Tsagris <mtsagris@yahoo.gr>
Date:   Fri Sep 29 16:40:29 2023 +0300

    Revert "change"

    This reverts commit 9cde21b.

commit 932bcaf
Author: Michail Tsagris <mtsagris@yahoo.gr>
Date:   Fri Sep 29 16:36:03 2023 +0300

    Revert "Revert "change""

    This reverts commit a2ff294.

commit a2ff294
Author: Michail Tsagris <mtsagris@yahoo.gr>
Date:   Fri Sep 29 16:34:30 2023 +0300

    Revert "change"

    This reverts commit 9cde21b.

commit a5dd5f9
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Fri Sep 29 15:34:38 2023 +0300

    update

commit 9cde21b
Author: statlink <mtsagris@yahoo.gr>
Date:   Fri Sep 8 17:50:27 2023 +0300

    change

commit 687b7a7
Author: statlink <mtsagris@yahoo.gr>
Date:   Fri Sep 8 17:40:14 2023 +0300

    Update jbtests.R

commit ecda610
Author: statlink <mtsagris@yahoo.gr>
Date:   Fri Sep 8 17:20:16 2023 +0300

    change

commit 18d7098
Author: statlink <mtsagris@yahoo.gr>
Date:   Fri Sep 8 10:34:42 2023 +0300

    change

commit 0bfdc51
Author: statlink <mtsagris@yahoo.gr>
Date:   Fri Sep 8 10:10:39 2023 +0300

    changes

commit e76727f
Author: statlink <mtsagris@yahoo.gr>
Date:   Fri Sep 8 10:06:45 2023 +0300

    changes

commit 9a20bf0
Author: statlink <mtsagris@yahoo.gr>
Date:   Thu Sep 7 19:29:00 2023 +0300

    Update univariate.mle.R

commit 3010fa5
Merge: bcb5f8f 23c639c
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Fri Jul 21 13:48:53 2023 +0300

    Merge branch 'master' into Dev

commit bcb5f8f
Merge: ed58ece 50eb865
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Fri Jul 21 13:45:55 2023 +0300

    Merge branch 'Dev' of https://github.com/RfastOfficial/Rfast2 into Dev

commit ed58ece
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Fri Jul 21 13:45:44 2023 +0300

    Update parallel.h

commit bd0cd71
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Fri Jul 21 13:45:40 2023 +0300

    update date

commit 50eb865
Author: statlink <mtsagris@yahoo.gr>
Date:   Wed Jul 19 16:45:31 2023 +0300

    change

commit 1511061
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Wed Jul 19 02:32:31 2023 +0300

    fix bug with clang and apple mac

commit d3d04e7
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Wed Jul 19 02:32:03 2023 +0300

    Update NEWS.md

commit feb5e2a
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Wed Jul 19 02:31:58 2023 +0300

    Update Rfast2-package.Rd

commit 6098801
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Wed Jul 19 02:31:51 2023 +0300

    Update DESCRIPTION

commit 1d214fa
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Wed Jul 12 18:29:49 2023 +0300

    add tbb

commit ea9d666
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Wed Jul 12 18:29:41 2023 +0300

    Update Rfast2-package.Rd

commit 59983ef
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Wed Jul 12 18:29:39 2023 +0300

    Update parallel.h

commit 8637164
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Wed Jul 12 18:29:33 2023 +0300

    Update DESCRIPTION

commit cae025a
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Tue Jul 11 17:49:28 2023 +0300

    add mising option parallel

commit f88875c
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Tue Jul 11 17:34:51 2023 +0300

    Update init.c

commit 2aaec6a
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Tue Jul 11 17:34:48 2023 +0300

    Update onAttach.R

commit 330f2bf
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Tue Jul 11 17:34:44 2023 +0300

    Update .Rbuildignore

commit ca46228
Merge: 55eb8d9 5bc90bc
Author: statlink <mtsagris@yahoo.gr>
Date:   Tue Jul 11 16:15:46 2023 +0300

    Merge branch 'Dev' of https://github.com/RfastOfficial/Rfast2 into Dev

commit 55eb8d9
Author: statlink <mtsagris@yahoo.gr>
Date:   Tue Jul 11 16:15:43 2023 +0300

    changes

commit 5bc90bc
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Mon Jul 10 17:24:38 2023 +0300

    add parallel to vector functions

commit 747beec
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Mon Jul 10 17:24:17 2023 +0300

    export to linking to functions and support c++17 parallelization

commit 565199d
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Mon Jul 10 17:23:46 2023 +0300

    change cores for omp by user

commit 220d057
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Mon Jul 10 17:23:06 2023 +0300

    Update init.c

commit 4cd20ed
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Mon Jul 10 17:23:03 2023 +0300

    Update Rfast2-package.Rd

commit ca4764d
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Mon Jul 10 17:22:59 2023 +0300

    Update NEWS.md

commit cec9c9d
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Mon Jul 10 17:22:54 2023 +0300

    remove system.time

commit 87b573f
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Mon Jul 10 17:22:40 2023 +0300

    support c++17 parallel ppolicy using RcppParallel

commit b47e649
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Mon Jul 10 17:21:15 2023 +0300

    Update DESCRIPTION

commit ea15df7
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Mon Jul 10 17:21:12 2023 +0300

    Update settings.json

commit 2603982
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Fri Jul 7 13:14:19 2023 +0300

    Update col_row_utilities.cpp

commit 0c23705
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Fri Jul 7 13:14:15 2023 +0300

    Delete templates.h

commit 3c17730
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Fri Jul 7 13:14:11 2023 +0300

    Update utilities.cpp

commit 3670e43
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Fri Jul 7 13:14:04 2023 +0300

    fix headers

commit 046fcc7
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Fri Jul 7 13:13:44 2023 +0300

    Update init.c

commit 74e3e13
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Fri Jul 7 13:13:38 2023 +0300

    fix headers

commit 5cc7bac
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Fri Jul 7 13:13:02 2023 +0300

    Update NEWS.md

commit 665065b
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Fri Jul 7 13:12:56 2023 +0300

    add core argument for parallelization

commit 36fdd77
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Fri Jul 7 13:11:34 2023 +0300

    code for checking concepts

commit 7b8b7ca
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Fri Jul 7 13:09:12 2023 +0300

    create for linking to

commit 6029327
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Fri Jul 7 12:57:52 2023 +0300

    Create settings.json

commit 1505a2c
Author: statlink <mtsagris@yahoo.gr>
Date:   Tue Apr 11 11:16:24 2023 +0300

    changes

commit c1c0c97
Author: statlink <mtsagris@yahoo.gr>
Date:   Sat Apr 8 11:13:26 2023 +0300

    changes

commit e44c596
Author: Manos Papadakis <papadakm95@gmail.com>
Date:   Wed Apr 5 16:49:30 2023 +0300

    fix bug
@ManosPapadakis95
Merge branch 'Dev'
2e7669d
@ManosPapadakis95
Merge branch 'Dev'
68c1ec5
@eddelbuettel
Switch from deprecated arma::is_finite to std::isfinite
f9cb2f5
@eddelbuettel eddelbuettel mentioned this pull request Sep 22, 2025
Closed
31 tasks
@ManosPapadakis95 ManosPapadakis95 changed the base branch from master to Dev October 6, 2025 09:32
@ManosPapadakis95 ManosPapadakis95 merged commit b3a6e21 into RfastOfficial:Dev Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eddelbuettel @ManosPapadakis95