[EXTERNAL] feat: expose revocationDate and revocationReason on StoreTransaction via @mvanhorn#7012
Merged
Merged
Conversation
Member
Author
|
@RCGitBot please test |
tonidero
approved these changes
Jun 16, 2026
tonidero
left a comment
Contributor
There was a problem hiding this comment.
Looks great! Thank you!
a2d7978 to
9415896
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9415896. Configure here.
c7ad1be to
a098239
Compare
Member
Author
|
@RCGitBot please test |
Member
Author
|
@RCGitBot please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains the original changes made by @mvanhorn in #6962 + added Objc compatibility
Note
Low Risk
Additive public API on transaction wrappers with SK1 and mocks unchanged (nil); no purchase or entitlement logic changes.
Overview
Adds public refund/revocation metadata on
StoreTransaction, aligned with StoreKit 2’sTransaction.revocationDateandTransaction.RevocationReason.Introduces
RevocationReason(developer_issue,other, raw-value + ObjCRCRevocationReason) and wires SK2 transactions to copyrevocationDateand map revocation reasons; unknown SK2 values log a warning and surface asnilon the reason. SK1, simulated, test, and backend-parsed transaction types returnnilfor both fields.StoreTransactionexposesrevocationDateandrevocationReasonon the public API (Swift and ObjC), with updated swiftinterfaces and API testers. Unit tests cover SK1 nil behavior, SK2 reason mapping, andRevocationReasonequality/switching.Reviewed by Cursor Bugbot for commit 3efd1a8. Bugbot is set up for automated code reviews on this repo. Configure here.