Skip to content

Add Slovenian locale support in paywalls#7007

Merged
MonikaMateska merged 1 commit into
mainfrom
monika/paywall/Slovene-locale-support
Jun 15, 2026
Merged

Add Slovenian locale support in paywalls#7007
MonikaMateska merged 1 commit into
mainfrom
monika/paywall/Slovene-locale-support

Conversation

@MonikaMateska

@MonikaMateska MonikaMateska commented Jun 15, 2026

Copy link
Copy Markdown
Member

Checklist

  • If applicable, unit tests
  • If applicable, create follow-up issues for purchases-android and hybrids

Motivation

Customer request (PWENG-115) to support Slovenian in paywalls. The existing workaround of substituting Slovenian for English only works for single-locale projects and breaks for customers with multiple locales.

Description

  • Added RevenueCatUI/Resources/sl.lproj/Localizable.strings with the Slovenian translations of the paywall strings.
  • Registered sl in RevenueCat.xcodeproj/project.pbxproj (file reference, knownRegions, and the Localizable.strings variant group).
  • Added test_sl_SI() to LocaleFinderTests to cover resolving the sl_SI locale to the sl localization

Note

Low Risk
Localization-only change with no runtime logic modifications; risk is limited to missing or incorrect Slovenian copy.

Overview
Adds ** Slovenian** as a first-class paywall locale so devices using sl_SI resolve to bundled strings instead of falling back to English in multi-locale apps.

Introduces sl.lproj/Localizable.strings with Slovene translations for the standard paywall keys (actions, subscription periods, restore/terms copy, and intro-offer template). Registers sl in the Xcode project (knownRegions and the Localizable.strings variant group). Adds test_sl_SI() in LocaleFinderTests to assert sl_SI maps to the sl localization, consistent with other language-only bundles.

Reviewed by Cursor Bugbot for commit 7e08a4e. Bugbot is set up for automated code reviews on this repo. Configure here.

@MonikaMateska MonikaMateska requested review from a team as code owners June 15, 2026 15:14

@tonidero tonidero left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I know the language... but looks good to me!

@MonikaMateska MonikaMateska changed the title Add Slovene locale support in paywalls Add Slovenian locale support in paywalls Jun 15, 2026
@MonikaMateska

Copy link
Copy Markdown
Member Author

Not that I know the language... but looks good to me!

Same here, I do understand it a bit thought. The translations seemed all fine.

@MonikaMateska MonikaMateska merged commit e6efe98 into main Jun 15, 2026
19 of 22 checks passed
@MonikaMateska MonikaMateska deleted the monika/paywall/Slovene-locale-support branch June 15, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants