Skip to content

Add macCatalyst availability check#6997

Merged
alexrepty merged 1 commit into
mainfrom
alex/fix-ci-issue
Jun 15, 2026
Merged

Add macCatalyst availability check#6997
alexrepty merged 1 commit into
mainfrom
alex/fix-ci-issue

Conversation

@alexrepty

@alexrepty alexrepty commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Extend the availability condition to include macCatalyst 18.0 when disabling allowsVideoFrameAnalysis. This ensures the defense-in-depth change (disabling AVKit video-frame-analysis to avoid AVPlayerController observer-related teardown crashes) is also applied for macCatalyst builds.

Checklist

  • If applicable, unit tests 
  • If applicable, create follow-up issues for purchases-android and hybrids 

Motivation

Resolves current CI build issues

Description

n/a


Note

Low Risk
Single-line availability fix with no behavior change on iOS; only aligns Mac Catalyst with an existing defensive AVKit setting.

Overview
Extends the #available check around allowsVideoFrameAnalysis = false in VideoPlayerUIView so it also applies on macCatalyst 18.0, not only iOS 16.0.

That keeps the existing teardown crash mitigation (turning off AVKit video-frame-analysis observers) active for Mac Catalyst builds and addresses the CI compile issue tied to the narrower availability condition.

Reviewed by Cursor Bugbot for commit 5515d2c. Bugbot is set up for automated code reviews on this repo. Configure here.

@alexrepty alexrepty requested a review from a team as a code owner June 15, 2026 09:34
@alexrepty alexrepty added the pr:fix A bug fix label Jun 15, 2026
@alexrepty alexrepty added pr:other and removed pr:fix A bug fix labels Jun 15, 2026
Extend the availability condition to include macCatalyst 18.0 when disabling allowsVideoFrameAnalysis. This ensures the defense-in-depth change (disabling AVKit video-frame-analysis to avoid AVPlayerController observer-related teardown crashes) is also applied for macCatalyst builds.
@alexrepty alexrepty force-pushed the alex/fix-ci-issue branch from e964fe7 to 5515d2c Compare June 15, 2026 09:38
@alexrepty alexrepty enabled auto-merge (squash) June 15, 2026 09:38
@alexrepty alexrepty merged commit c8c9537 into main Jun 15, 2026
18 of 20 checks passed
@alexrepty alexrepty deleted the alex/fix-ci-issue branch June 15, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants