Add macCatalyst availability check#6997
Merged
Merged
Conversation
ajpallares
approved these changes
Jun 15, 2026
Extend the availability condition to include macCatalyst 18.0 when disabling allowsVideoFrameAnalysis. This ensures the defense-in-depth change (disabling AVKit video-frame-analysis to avoid AVPlayerController observer-related teardown crashes) is also applied for macCatalyst builds.
e964fe7 to
5515d2c
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the availability condition to include macCatalyst 18.0 when disabling allowsVideoFrameAnalysis. This ensures the defense-in-depth change (disabling AVKit video-frame-analysis to avoid AVPlayerController observer-related teardown crashes) is also applied for macCatalyst builds.
Checklist
If applicable, unit testsIf applicable, create follow-up issues forpurchases-androidand hybridsMotivation
Resolves current CI build issues
Description
n/a
Note
Low Risk
Single-line availability fix with no behavior change on iOS; only aligns Mac Catalyst with an existing defensive AVKit setting.
Overview
Extends the
#availablecheck aroundallowsVideoFrameAnalysis = falseinVideoPlayerUIViewso it also applies on macCatalyst 18.0, not only iOS 16.0.That keeps the existing teardown crash mitigation (turning off AVKit video-frame-analysis observers) active for Mac Catalyst builds and addresses the CI compile issue tied to the narrower availability condition.
Reviewed by Cursor Bugbot for commit 5515d2c. Bugbot is set up for automated code reviews on this repo. Configure here.