Use a snapshot-env-free macOS executor for update-error-codes#6995
Merged
Conversation
macos-executor embeds pipeline.parameters.generate_snapshots / generate_revenuecatui_snapshots in its environment, which don't resolve when the executor is evaluated outside this config's pipeline-parameter scope (e.g. inside the revenuecat/update-error-codes orb job — the #13 merge errored the iOS pipeline with "Unknown variable(s)"). Add macos-executor-external (macos-executor minus that snapshot env) and use it for the update-error-codes job.
83977c4 to
1e846fc
Compare
ajpallares
approved these changes
Jun 15, 2026
ajpallares
left a comment
Member
There was a problem hiding this comment.
Thanks for the fix! I think it makes sense!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default
macos-executorhas two pipeline parameters for snapshots as environment variables. When passed to an external orb, it can't resolve them, causing an errorTo work around this, I've defined a separate executor for external use that just hardcodes the envs to false.
Note
Low Risk
CI configuration only; no application or SDK code changes, and snapshot env behavior for the error-codes job is intentionally fixed to false.
Overview
Fixes CircleCI Unknown variable(s) failures when the
revenuecat/update-error-codesorb job receives the defaultmacos-executor, whose environment still references<< pipeline.parameters.generate_snapshots >>and related snapshot flags that do not resolve inside the orb’s config scope.Adds
macos-executor-external, mirroring the standard macOS executor but hardcodingCIRCLECI_TESTS_GENERATE_SNAPSHOTSandCIRCLECI_TESTS_GENERATE_REVENUECAT_UI_SNAPSHOTSto"false", and wires theupdate-error-codesworkflow to use it instead ofmacos-executor.Reviewed by Cursor Bugbot for commit 1e846fc. Bugbot is set up for automated code reviews on this repo. Configure here.