Adopt generated ErrorCode#6970
Merged
Merged
Conversation
559f10f to
b7312d9
Compare
ajpallares
reviewed
Jun 10, 2026
ajpallares
left a comment
Member
There was a problem hiding this comment.
Looking good! Some comments and 1 concern about merging this before the follow-up for the macOS-specific error description
Contributor
Author
Yes, I'll make that PR and see if it's worth it or if we should remove it |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
There are 3 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e52db91. Configure here.
rickvdl
reviewed
Jun 11, 2026
58191a7 to
233609d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace hand-written
ErrorCodewith the file generated by purchases-error-codes. No API changes.Requires a small refactor to extract handwritten conformances out of ErrorCode
Note
Medium Risk
Touches the public
ErrorCodeAPI and error messaging; removingreservedRawValuesand@unknown defaultshifts how future enum cases are handled compared to the old hand-written file.Overview
Replaces the hand-maintained
ErrorCodedefinition with a generated copy underSources/Generated/, sourced from purchases-error-codes, and wires it into Xcode via a new Generated group.SDK-specific pieces that must not be overwritten by codegen move to
ErrorCode+Conformances.swift:DescribableErroronErrorCode, plus thePurchasesErrorConvertibleprotocol and its default helpers (previously inline inErrorCode.swift).The generated enum keeps the same cases, raw values,
description/codeName, andCustomNSErrorbehavior, with small copy edits (e.g. unsupported-error wording, trailing periods). Switches in the generated file are fully exhaustive and drop@unknown defaultandreservedRawValues; the unit test that guarded against reusing removed raw values is removed.swiftlint-baseline.jsonis updated so the public-enum rule still points at the new file path. Publishedapi/*.swiftinterfacefiles reflect a minor declaration order change aroundPublicError/ErrorCodewith no intended API surface change.Reviewed by Cursor Bugbot for commit 233609d. Bugbot is set up for automated code reviews on this repo. Configure here.