Skip to content

fix: skip RootView layout snapshot tests on iOS 15#6953

Merged
ajpallares merged 2 commits into
mainfrom
pallares/skip-form-sheet-snapshot-ios15
Jun 8, 2026
Merged

fix: skip RootView layout snapshot tests on iOS 15#6953
ajpallares merged 2 commits into
mainfrom
pallares/skip-form-sheet-snapshot-ios15

Conversation

@ajpallares

@ajpallares ajpallares commented Jun 8, 2026

Copy link
Copy Markdown
Member

Motivation

RootViewLayoutSnapshotTests have been failing in iOS 15 since we added the snapshot validation test for it. For some reason, the snapshots render differently on iOS 15.

Description

Guards both tests to run only on iOS 16+, skipping them on iOS 15 via XCTSkip, as a temporary workaround to unblock the release of #6949

The form sheet snapshot renders inconsistently on iOS 15, causing the
test to fail. Guard it to run only on iOS 16+ as a temporary fix.

Co-authored-by: Cursor <cursoragent@cursor.com>
@ajpallares

Copy link
Copy Markdown
Member Author

@RCGitBot please test spm-revenuecat-ui-ios-15

@ajpallares ajpallares marked this pull request as ready for review June 8, 2026 21:15
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

🚀 Triggered spm-revenuecat-ui-ios-15Pipeline #39052

@ajpallares ajpallares requested a review from a team as a code owner June 8, 2026 21:15
The snapshot also renders inconsistently on iOS 15.

Co-authored-by: Cursor <cursoragent@cursor.com>

@fire-at-will fire-at-will left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving for now so we can ship the Xcode 27 beta fix, though we might want to find the root cause of this difference for now.

@ajpallares

Copy link
Copy Markdown
Member Author

@RCGitBot please test spm-revenuecat-ui-ios-15

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

🚀 Triggered spm-revenuecat-ui-ios-15Pipeline #39054

@ajpallares ajpallares changed the title fix: skip iPad form sheet snapshot test on iOS 15 fix: skip RootView layout snapshot tests on iOS 15 Jun 8, 2026
@ajpallares ajpallares merged commit 68ea9f7 into main Jun 8, 2026
38 of 42 checks passed
@ajpallares ajpallares deleted the pallares/skip-form-sheet-snapshot-ios15 branch June 8, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants