Fix badge stack shadow not being rendered#6921
Merged
MonikaMateska merged 1 commit intoJun 5, 2026
Merged
Conversation
vegaro
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
purchases-androidand hybridsMotivation
A drop shadow configured on a paywall badge (the badge's inner stack
shadow) rendered on Android but was silently dropped on iOS, badge shadows have never rendered on iOS.Root cause:
BadgeModifierapplied the badge stack'spadding,background,borderandshape, but never itsshadow, in all four render paths (overlaid, nested, edge-to-edge corners, edge-to-edge top/bottom).Resolves: PWENG-104
Testing
Note
Low Risk
Scoped SwiftUI presentation fix in BadgeModifier with no auth, data, or purchase-flow changes.
Overview
Paywalls V2 badge stacks now render configured drop shadows on iOS, matching Android and other stack components.
BadgeModifierreadscolorScheme, resolves the inner badge stack’sshadowintoShadowModifier.ShadowInfo, and passes it through overlaid, nested, edge-to-edge corner, and edge-to-edge top/bottom (EdgeToEdgeTopBottomModifier) paths via.shadow(shadow:shape:).Reviewed by Cursor Bugbot for commit 80ab19a. Bugbot is set up for automated code reviews on this repo. Configure here.