Fix decoded image cache concurrency deadlock#6907
Merged
Merged
Conversation
Co-authored-by: Cesar de la Vega <vegaro@users.noreply.github.com>
Member
|
@RCGitBot please test |
Co-authored-by: Cesar de la Vega <vegaro@users.noreply.github.com>
rickvdl
approved these changes
Jun 4, 2026
rickvdl
left a comment
Member
There was a problem hiding this comment.
Thanks for fixing and your thorough investigation!
Contributor
|
Thanks @vegaro for this fix! Already fixing an issue in a ticket! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Paywalls can request several cached images from Swift concurrency tasks during first presentation.
DecodedImageCachewrappedNSCacheaccess in a concurrentDispatchQueueusing synchronous reads and asynchronous barrier writes. Blocking Swift cooperative pool threads on that GCD queue can starve the pool and deadlock image loading, which can also prevent subscriber actions from running.Description
DecodedImageCacheand useNSCachedirectly, sinceNSCacheis thread-safe.Slack Thread