Skip to content

Bump Max Log Count in Tests#6901

Merged
fire-at-will merged 1 commit into
mainfrom
bump-log-count
Jun 3, 2026
Merged

Bump Max Log Count in Tests#6901
fire-at-will merged 1 commit into
mainfrom
bump-log-count

Conversation

@fire-at-will

@fire-at-will fire-at-will commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Description

The record-and-push-paywall-template-screenshots job is failing in main because we've exceeded the max log count:

testPaywallValidationScreenshots, 1018 messages have been stored. This is likely a programming error and PaywallScreenshotTests.TestLogHandler (created by -[TakeScreenshotTests testPaywallValidationScreenshots] in PaywallScreenshotTests/TestCase.swift:30 has leaked.

This PR bumps the max log count from 1k to 10k to attempt to alleviate this issue.


Note

Low Risk
Test-only logging limit change with no impact on app runtime, security, or data handling.

Overview
Raises the per-test log buffer on the shared UI test base class from 1,000 to 10,000 messages so verbose flows (e.g. paywall validation screenshot tests) no longer trip the “max messages stored / likely leak” guard in CI.

Reviewed by Cursor Bugbot for commit 81bf1ac. Bugbot is set up for automated code reviews on this repo. Configure here.

@fire-at-will fire-at-will requested a review from a team as a code owner June 3, 2026 17:35
@fire-at-will fire-at-will changed the title Bump Max Log Count Bump Max Log Count in Tests Jun 3, 2026
@fire-at-will fire-at-will merged commit 661fbb9 into main Jun 3, 2026
19 of 22 checks passed
@fire-at-will fire-at-will deleted the bump-log-count branch June 3, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants