Skip to content

fix(tests): add missing iOS 14/15 snapshots for BackendGetWorkflowsListTests#6861

Merged
rickvdl merged 1 commit into
mainfrom
rickvdl/fix-ios14-15-workflow-tests
May 28, 2026
Merged

fix(tests): add missing iOS 14/15 snapshots for BackendGetWorkflowsListTests#6861
rickvdl merged 1 commit into
mainfrom
rickvdl/fix-ios14-15-workflow-tests

Conversation

@rickvdl

@rickvdl rickvdl commented May 28, 2026

Copy link
Copy Markdown
Member

Summary

PR #6853 added snapshot tests and reference snapshots for iOS 16 and up, missing the iOS 14 / 15 ones. Causing CI to fail on these iOS versions.


Note

Low Risk
Test-only snapshot additions with no runtime or networking behavior changes.

Overview
Adds 12 reference snapshot files under Tests/UnitTests/Networking/Backend/__Snapshots__/BackendGetWorkflowsTests/ so BackendGetWorkflowsListTests (six cases × iOS 14 and iOS 15) can pass on the iOS 14/15 CI job.

Snapshots record the expected GET to https://api.revenuecat.com/v1/subscribers/user/workflows (and ?type=paywall for the type-filter test), with standard RevenueCat client headers including StoreKit 1 (X-StoreKit-Version: 1, X-StoreKit2-Enabled: false). No production or test Swift code is modified.

Reviewed by Cursor Bugbot for commit c054ceb. Bugbot is set up for automated code reviews on this repo. Configure here.

…stTests

PR #6853 added getWorkflows list tests with snapshots for iOS 16-18, 26,
macOS, tvOS, and watchOS, but omitted iOS 14 and iOS 15. The run-test-ios-15-and-14
CI job fails because swift-snapshot-testing finds no reference files for the
6 new testGetWorkflows* tests on those platforms.

iOS 14/15 use StoreKit 1 (X-StoreKit-Version: 1, X-StoreKit2-Enabled: false),
matching the pattern of existing iOS14/15 snapshots in this suite.
@rickvdl rickvdl requested a review from a team as a code owner May 28, 2026 09:31
@rickvdl rickvdl added the pr:fix A bug fix label May 28, 2026
@rickvdl

rickvdl commented May 28, 2026

Copy link
Copy Markdown
Member Author

@RCGitBot please test

@ajpallares ajpallares left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@rickvdl rickvdl merged commit 1ebd907 into main May 28, 2026
44 checks passed
@rickvdl rickvdl deleted the rickvdl/fix-ios14-15-workflow-tests branch May 28, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants