ci(admob): run revenuecat-admob-tests on every PR push#6850
Merged
Conversation
Move the job out of the approve-full-tests gate in run-all-tests so it executes automatically on each push rather than waiting for manual approval.
ajpallares
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
revenuecat-admob-testsout of theapprove-full-testsgate in therun-all-testsworkflowrelease-or-mainworkflow is unchanged (it was already ungated there)Follow-up required (admin access needed)
Add
ci/circleci: revenuecat-admob-testsas a required status check formain. Run this once the PR merges and a passing CircleCI build has reported the new context:Or add it through the GitHub UI: Settings → Branches → main → Edit → Require status checks → search for
revenuecat-admob-tests.Test plan
revenuecat-admob-testsautomatically on this PR without needing to approve the gateNote
Low Risk
CI workflow-only change; no application code, with slightly more macOS CI usage per PR push.
Overview
In the
run-all-testsCircleCI workflow,revenuecat-admob-testsis now part of the reduced test suite that runs on every PR push (withslack-secrets), instead of sitting behindapprove-full-tests.The job is removed from the gated full-suite block (no more
requires: approve-full-tests).all-tasks-passedstill depends onrevenuecat-admob-tests, so merge gating can treat it as required once GitHub branch protection lists the CircleCI status check.Follow-up outside this diff: add
ci/circleci: revenuecat-admob-testsas a required check onmainafter a green build reports that context.Reviewed by Cursor Bugbot for commit 6eb1388. Bugbot is set up for automated code reviews on this repo. Configure here.