fix(ads/admob): update test fakes for non-optional CapableAd.responseInfo#6849
Merged
Conversation
…Info Both FakeRewardedAd and FakeCapableAd still declared responseInfo as Optional, breaking the test target's build after the protocol change.
ajpallares
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CapableAd.responseInfonon-optional, but the test fakes (FakeRewardedAd,FakeCapableAd) still declared it asResponseInfo?, so theRevenueCatAdMobTeststarget no longer compiles on main.let responseInfo = GoogleMobileAds.ResponseInfo()to match the protocol.Test plan
xcodebuild ... -workspace AdapterSDKs/RevenueCatAdMob -scheme RevenueCatAdMob test— 168 tests pass locallyci/circleci: revenuecat-admob-testsgreenNote
Low Risk
Test-only changes with no production or security impact.
Overview
Restores RevenueCatAdMob test compilation after
RewardVerification.CapableAd.responseInfobecame non-optional. Test doublesFakeCapableAdandFakeRewardedAdnow exposelet responseInfo = GoogleMobileAds.ResponseInfo()instead of optionalResponseInfo?.Reviewed by Cursor Bugbot for commit 8db7dba. Bugbot is set up for automated code reviews on this repo. Configure here.