Nice catch! I think we introduced this when we added Paywall support for CustomerCenter.

I suspect the root cause is that PresentingCustomerCenterModifier holds the handler as a @StateObject. However, inside the paywall the handler is already owned and injected by PaywallsV2View (.environmentObject(self.purchaseHandler)), and ButtonComponentView reads it as @EnvironmentObject. So having the modifier own a second one is what lead to the bug in my opinion.

If the paywall path instead observed the existing handler rather than owning it, the binding alone would be enough. The A small paywall-internal modifier could do:

  private struct PaywallCustomerCenterSheetModifier: ViewModifier {
      @EnvironmentObject private var purchaseHandler: PurchaseHandler
      @Binding var isPresented: Bool
      let onDismiss: (() -> Void)?

      func body(content: Content) -> some View {
          content.sheet(isPresented: $isPresented, onDismiss: onDismiss) {
              CustomerCenterView()
                  ....
          }
      }
  }

Totally fine to ship as-is and tackle the ownership cleanup separately.

Did some quick sanity check testing

• Customer center still shows up as it should
• No evidence of extraneous PurchaseHandler initializations during redraws observed

Nice catch! I think we introduced this when we added Paywall support for CustomerCenter.

I suspect the root cause is that PresentingCustomerCenterModifier holds the handler as a @StateObject. However, inside the paywall the handler is already owned and injected by PaywallsV2View (.environmentObject(self.purchaseHandler)), and ButtonComponentView reads it as @EnvironmentObject. So having the modifier own a second one is what lead to the bug in my opinion.

If the paywall path instead observed the existing handler rather than owning it, the binding alone would be enough. The A small paywall-internal modifier could do:

  private struct PaywallCustomerCenterSheetModifier: ViewModifier {
      @EnvironmentObject private var purchaseHandler: PurchaseHandler
      @Binding var isPresented: Bool
      let onDismiss: (() -> Void)?

      func body(content: Content) -> some View {
          content.sheet(isPresented: $isPresented, onDismiss: onDismiss) {
              CustomerCenterView()
                  ....
          }
      }
  }

Totally fine to ship as-is and tackle the ownership cleanup separately.

Created PWENG-101 for this change, so we can unblock this PR and merge.