Add conditional visibility to ButtonComponent by facumenzella · Pull Request #6821 · RevenueCat/purchases-ios

facumenzella · 2026-05-19T23:51:16Z

Summary

Ports the button-conditional-visibility feature from Android to iOS. Buttons can now declare a visible field and an overrides array, allowing visibility to be toggled conditionally (e.g., hide a back button when a package is selected).

Adds visible: Bool? and overrides: ComponentOverrides<PartialButtonComponent>? to ButtonComponent
Adds PartialButtonComponent (mirrors Android's PresentedButtonPartial)
Adds PresentedPartial conformance and a visible(state:condition:...) method on ButtonComponentViewModel, resolving button-level overrides independently of the stack
Updates ButtonComponentView.isVisible to use button-level override resolution
Updates containsUnsupportedConditions() in PresentedPartials.swift to recurse into a button's own overrides
Threads discardRules and uiConfigProvider through ViewModelFactory into ButtonComponentViewModel

Test plan

ButtonComponentViewModelMappingTests — unit tests for visible(...) covering default visibility, visible: false, selected override hiding, and selected override not hiding when not selected
ToPresentedOverridesTests — two new cases: button with unsupported condition in its own overrides returns true; button with supported condition returns false
ButtonComponentViewTests — view-level rendering tests using UIHostingController confirming visible: false hides the button, visible: true shows it, and a .selected override with visible: false hides when componentViewState = .selected

🤖 Generated with Claude Code

Note

Medium Risk
Adds new serialized fields and override evaluation that can hide/show paywall buttons at runtime, which could unintentionally suppress navigation/restore actions if misconfigured. Changes are localized to Paywalls V2 button rendering/mapping and are covered by new unit and view tests.

Overview
Adds conditional visibility to Paywalls V2 buttons by extending PaywallComponent.ButtonComponent with visible plus overrides (via new PartialButtonComponent) and including these fields in coding/hash/equality.

Updates ButtonComponentViewModel/ButtonComponentView to evaluate button-level overrides (using UIConfigProvider + selection/eligibility/custom-variable context) and skip rendering when the resolved visibility is false; ViewModelFactory now threads uiConfigProvider and the global discardRules flag into the button view model, and unsupported-condition detection now also checks a button’s own overrides.

Adds coverage with new/expanded tests for visibility resolution and actual SwiftUI rendering (ButtonComponentViewTests), and registers the new test file in the Xcode project.

^{Reviewed by Cursor Bugbot for commit dfc94a7. Bugbot is set up for automated code reviews on this repo. Configure here.}

Port Android's button-conditional-visibility feature: adds visible and overrides fields to ButtonComponent and PartialButtonComponent, resolves button-level overrides in ButtonComponentViewModel, and gates rendering in ButtonComponentView on the result. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

vegaro

little nits. Good to go after testing it

…ody, add conditional-visibility previews Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

emerge-tools · 2026-05-20T16:27:38Z

📸 Snapshot Test

1 modified, 2 added, 266 unchanged

Name	Added	Removed	Modified	Renamed	Unchanged	Errored	Approval
RevenueCat com.revenuecat.PaywallsTester	2	0	1	0	266	0	✅ Approved

🛸 Powered by Emerge Tools

…e and hidden states Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

emerge-tools · 2026-05-20T16:50:19Z

4 builds increased size

Name	Version	Download	Change	Install	Change	Approval
RevenueCat com.revenuecat.PaywallsTester	1.0 (1)	18.1 MB	⬆️ 34.1 kB (0.19%)	65.1 MB	⬆️ 175.6 kB (0.27%)	N/A
BinarySizeTest com.revenuecat.binary-size-test.local-source	1.0 (1)	4.1 MB	⬆️ 3.9 kB (0.1%)	12.4 MB	⬆️ 19.1 kB (0.16%)	N/A
BinarySizeTest com.revenuecat.binary-size-test.cocoapods	1.0 (1)	6.2 MB	⬆️ 7.9 kB (0.13%)	27.3 MB	⬆️ 35.8 kB (0.13%)	⏳ Needs approval
BinarySizeTest com.revenuecat.binary-size-test.spm	1.0 (1)	4.2 MB	⬆️ 5.2 kB (0.12%)	10.8 MB	⬆️ 10.9 kB (0.1%)	N/A

RevenueCat 1.0 (1)
com.revenuecat.PaywallsTester

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 175.6 kB (0.27%)
Total download size change: ⬆️ 34.1 kB (0.19%)

Largest size changes

Item	Install Size Change
DYLD.String Table	⬆️ 73.9 kB
Code Signature	⬆️ 4.2 kB
DYLD.Exports	⬆️ 2.0 kB
📝 RevenueCat.PaywallComponent.PartialButtonComponent.PartialButtonC...	⬆️ 1.4 kB
RevenueCatUI.ButtonComponentViewModel.ButtonComponentViewModel	⬆️ 1.2 kB

View Treemap

BinarySizeTest 1.0 (1)
com.revenuecat.binary-size-test.local-source

⚖️ Compare build
📦 Install build
⏱️ Analyze build performance

Total install size change: ⬆️ 19.1 kB (0.16%)
Total download size change: ⬆️ 3.9 kB (0.1%)

Largest size changes

Item	Install Size Change
RevenueCat.PaywallComponent.ButtonComponent.ButtonComponent	⬆️ 3.5 kB
RevenueCat.PaywallComponent.PackageComponent.PackageComponent	⬇️ -3.4 kB
📝 RevenueCatUI.ButtonComponentViewModel.init(component,localization...	⬆️ 3.1 kB
🗑 RevenueCatUI.ButtonComponentViewModel.init(component,localization...	⬇️ -2.4 kB
RevenueCatUI.ButtonComponentView.body	⬆️ 2.0 kB

View Treemap

BinarySizeTest 1.0 (1)
com.revenuecat.binary-size-test.cocoapods

⚖️ Compare build
📦 Install build
⏱️ Analyze build performance

Total install size change: ⬆️ 35.8 kB (0.13%)
Total download size change: ⬆️ 7.9 kB (0.13%)

Largest size changes

Item	Install Size Change
DYLD.String Table	⬆️ 12.4 kB
RevenueCat.PaywallComponent.ButtonComponent.ButtonComponent	⬆️ 3.5 kB
RevenueCat.PaywallComponent.PackageComponent.PackageComponent	⬇️ -3.4 kB
DYLD.String Table	⬆️ 3.2 kB
📝 RevenueCatUI.ButtonComponentViewModel.init(component,localization...	⬆️ 3.1 kB

View Treemap

BinarySizeTest 1.0 (1)
com.revenuecat.binary-size-test.spm

⚖️ Compare build
📦 Install build
⏱️ Analyze build performance

Total install size change: ⬆️ 10.9 kB (0.1%)
Total download size change: ⬆️ 5.2 kB (0.12%)

Largest size changes

Item	Install Size Change
RevenueCat.PaywallComponent.ButtonComponent.ButtonComponent	⬆️ 3.5 kB
RevenueCat.PaywallComponent.PackageComponent.PackageComponent	⬇️ -3.4 kB
📝 RevenueCatUI.ButtonComponentViewModel.init(component,localization...	⬆️ 3.1 kB
🗑 RevenueCatUI.ButtonComponentViewModel.init(component,localization...	⬇️ -2.4 kB
RevenueCatUI.ButtonComponentView.body	⬆️ 2.0 kB

View Treemap

🛸 Powered by Emerge Tools

Comment trigger: Size diff threshold of 100.00kB exceeded

…behavior adds no value Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

facumenzella · 2026-05-20T17:01:28Z

Added some previews @vegaro !

facumenzella added pr:feat A new feature pr:RevenueCatUI feat:PaywallV2 labels May 19, 2026

Add ButtonComponentViewTests.swift to RevenueCat.xcodeproj

4fc626b

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

vegaro approved these changes May 20, 2026

View reviewed changes

Comment thread RevenueCatUI/Templates/V2/Components/Button/ButtonComponentView.swift Outdated

Comment thread RevenueCatUI/Templates/V2/Components/Button/ButtonComponentView.swift Outdated

Address vegaro nits: remove unused colorScheme, inline visible() in b…

2f9a639

…ody, add conditional-visibility previews Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Improve conditional-visibility previews to show button in both visibl…

32c96d1

…e and hidden states Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Remove testButtonWithVisibleTrue_IsRendered — testing default render …

36dc18a

…behavior adds no value Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

facumenzella marked this pull request as ready for review May 20, 2026 17:01

facumenzella requested review from a team as code owners May 20, 2026 17:01

Merge branch 'main' into worktree-partitioned-moseying-cloud

dfc94a7

facumenzella enabled auto-merge (squash) May 20, 2026 17:01

facumenzella merged commit ef1bf10 into main May 20, 2026
16 of 19 checks passed

facumenzella deleted the worktree-partitioned-moseying-cloud branch May 20, 2026 17:12

facumenzella added pr:fix A bug fix and removed pr:feat A new feature labels May 22, 2026

This was referenced May 22, 2026

[AUTOMATIC] Release/5.73.2 #6835

Closed

[AUTOMATIC] Release/5.74.0 #6836

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add conditional visibility to ButtonComponent#6821

Add conditional visibility to ButtonComponent#6821
facumenzella merged 6 commits into
mainfrom
worktree-partitioned-moseying-cloud

facumenzella commented May 19, 2026 •

edited by cursor Bot

Loading

Uh oh!

vegaro left a comment

Uh oh!

Uh oh!

Uh oh!

emerge-tools Bot commented May 20, 2026 •

edited

Loading

Uh oh!

emerge-tools Bot commented May 20, 2026 •

edited

Loading

Uh oh!

facumenzella commented May 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

facumenzella commented May 19, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

vegaro left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

emerge-tools Bot commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📸 Snapshot Test

1 modified, 2 added, 266 unchanged

Uh oh!

emerge-tools Bot commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

4 builds increased size

RevenueCat 1.0 (1)com.revenuecat.PaywallsTester

BinarySizeTest 1.0 (1)com.revenuecat.binary-size-test.local-source

BinarySizeTest 1.0 (1)com.revenuecat.binary-size-test.cocoapods

BinarySizeTest 1.0 (1)com.revenuecat.binary-size-test.spm

Uh oh!

facumenzella commented May 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

facumenzella commented May 19, 2026 •

edited by cursor Bot

Loading

emerge-tools Bot commented May 20, 2026 •

edited

Loading

emerge-tools Bot commented May 20, 2026 •

edited

Loading

RevenueCat 1.0 (1)
com.revenuecat.PaywallsTester

BinarySizeTest 1.0 (1)
com.revenuecat.binary-size-test.local-source

BinarySizeTest 1.0 (1)
com.revenuecat.binary-size-test.cocoapods

BinarySizeTest 1.0 (1)
com.revenuecat.binary-size-test.spm