Pass Customer Center's change plans configuration when loading expired transactions#6809
Closed
bilqisium wants to merge 1 commit into
Closed
Pass Customer Center's change plans configuration when loading expired transactions#6809bilqisium wants to merge 1 commit into
bilqisium wants to merge 1 commit into
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When a subscription is expired, and we have filtered subscription by configuring
Configure switchable subscriptionsin the Customer Center, the filter wouldn't be applied.Description
Fix the bug. Pass the change plans configuration when loading expired subscriptions.
Note
Low Risk
Low risk bug fix that only changes how
changePlansconfiguration is passed when constructing purchase info for expired subscriptions; no auth or data persistence changes.Overview
Fixes Customer Center subscription filtering for expired subscriptions by passing
configuration.changePlans(instead of an empty list) when buildingPurchaseInformationfor the most recent expired transaction.This makes the switchable subscriptions / change-plan configuration apply consistently for both active and expired subscription displays.
Reviewed by Cursor Bugbot for commit 99f3d68. Bugbot is set up for automated code reviews on this repo. Configure here.