[Billing Plans]: Fix: Dont return products for compound product IDs when in SK1 Mode#6806
Merged
fire-at-will merged 8 commits intoMay 19, 2026
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 24d5f0d. Configure here.
JZDesign
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where requesting a product with a compound product ID, like
com.rc.product:monthly, when running the SDK in StoreKit 1 mode, would return aStoreProductwith no InstallmentsInfo object. This is incorrect behavior and could result in you getting back the same product twice if you requested bothcom.rc.product:monthlyandcom.rc.product.This PR fixes this by:
Note
Medium Risk
Changes product identifier normalization and filtering so compound billing-plan IDs are ignored in StoreKit 1, which can alter which products are returned and which requests are made.
Overview
Fixes product fetching so compound product identifiers with billing plans (e.g.
com.app.sub:monthly) are never returned or requested when running in StoreKit 1, preventing duplicate/incorrectStoreProductresults.Adds a new warning log
sk1_does_not_support_billing_plansand centralizes billing-plan support checks inProductsManager.areProductsWithBillingPlansSupported(SK2 + OS availability), with updated/expanded unit tests to assert the correct empty results and warning behavior across OS versions and StoreKit modes.Reviewed by Cursor Bugbot for commit dbcd8a7. Bugbot is set up for automated code reviews on this repo. Configure here.