[Billing Plans]: fix: Don't return products with billing plans on unsupported OS versions#6805
Merged
fire-at-will merged 4 commits intoMay 15, 2026
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 561b46e. Configure here.
MarkVillacampa
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes a bug where fetching a product with a billing plan (like
com.rc.product:monthly) on iOS <26.4 would return the base product, but with a nilInstallmentsInfo. This is functionally equivalent to returning the same product twice.The PR addresses this bug by:
I'll follow up this PR with a similar change to assert that we don't return any products for compound product identifiers when running in SK1 mode.
Note
Medium Risk
Changes product fetching behavior by filtering out compound product identifiers with billing plans on iOS < 26.4, which could affect apps relying on prior (buggy) fallback behavior. Logic is gated by OS availability and covered by new unit tests, reducing regression risk.
Overview
Fixes SK2 product fetching so compound product identifiers that include billing plans (e.g.
product:monthly) are ignored on OS versions where billing plans aren’t supported (< iOS 26.4), preventing the base product from being returned as an unintended fallback.Adds a new warning log (
sk2_billing_plans_are_unavailable_on_this_os_version) when these requests are omitted, and updates unit tests + availability helpers to validate both supported and unsupported OS behaviors.Reviewed by Cursor Bugbot for commit ed1fdb6. Bugbot is set up for automated code reviews on this repo. Configure here.