Rename reward verification completion callback#6800
Merged
Conversation
ajpallares
approved these changes
May 15, 2026
ajpallares
left a comment
Member
There was a problem hiding this comment.
Makes sense. Although this is a public API, I think it's fine because it's experimental. And I agree the new name is clearly better 👍
ajpallares
reviewed
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
purchases-androidand hybridsMotivation
Small naming improvement. The reward verification completion callback should use a name that describes when it fires, matching
rewardVerificationStartedwithrewardVerificationCompleted.Description
Renamed the AdMob reward verification callback label from
rewardVerificationResulttorewardVerificationCompletedacross the adapter API, tests, examples, README snippets, and changelog entries.Tested with:
swift testfromAdapterSDKs/RevenueCatAdMobgit diff --checkNote
Medium Risk
This is a source-breaking API surface change for reward-verification presentation callbacks, requiring downstream code updates. Runtime behavior is intended to be unchanged aside from the renamed parameter label.
Overview
Renames the reward-verification completion callback label from
rewardVerificationResulttorewardVerificationCompletedfor rewarded and rewarded-interstitialpresent(...)APIs inRewardedAds+RewardVerification.swift.Updates all call sites and documentation to match (sample app managers, adapter README snippet, and Swift API surface/unit tests) so reward verification flows now consistently use
rewardVerificationStarted/rewardVerificationCompleted.Reviewed by Cursor Bugbot for commit 97cc7ef. Bugbot is set up for automated code reviews on this repo. Configure here.