Purchasing products with billing plans#6772
Merged
fire-at-will merged 48 commits intoMay 14, 2026
Merged
Conversation
…ntroduce billingPlanIdentifier
…roducts-with-billing-plans
…roducts-with-billing-plans
Base automatically changed from
fetching-products-with-billing-plans
to
billing-plans-dev
May 13, 2026 20:37
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f8a3e38. Configure here.
Contributor
Author
|
After a discussion with @MarkVillacampa in Slack, we decided not to apply |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for purchasing products with billing plans!
Testing
Note
Medium Risk
Touches the StoreKit 2 purchase flow by conditionally adding a new
.billingPlanTypepurchase option and throwing when a plan is ineligible, which can change purchase outcomes on iOS 26.4+ devices. Guarded by OS/compiler availability but still impacts a critical revenue path.Overview
Adds StoreKit 2 support for purchasing subscription products using Apple billing plans (installments) on iOS/macOS/tvOS/watchOS/visionOS 26.4+.
PurchasesOrchestratornow plumbs aBillingPlanTypethrough the SK2 purchase path, conditionally applies.billingPlanTypewhen the plan is present and eligible (based onsubscription.pricingTerms), and fails fast withproductNotAvailableForPurchaseError()when the user isn’t eligible. Logging was extended with new messages for applying a plan vs. rejecting an ineligible plan, andBillingPlanTypegained a mapping back to StoreKit’sBillingPlanType; tests and the SwiftUI purchase tester were updated accordingly.Reviewed by Cursor Bugbot for commit 04adb9a. Bugbot is set up for automated code reviews on this repo. Configure here.