Skip to content

Don't send interaction event for workflow trigger button actions#6771

Merged
facumenzella merged 8 commits into
mainfrom
cesar/remove-workflow-trigger-event
May 29, 2026
Merged

Don't send interaction event for workflow trigger button actions#6771
facumenzella merged 8 commits into
mainfrom
cesar/remove-workflow-trigger-event

Conversation

@vegaro

@vegaro vegaro commented May 12, 2026

Copy link
Copy Markdown
Member

When a button with a workflow trigger action is tapped, we were sending a componentInteraction event before handing control off to the workflow navigator. This was a placeholder that we are removing now. We are not sending events for this interaction for now.


Note

Low Risk
Analytics-only change in Paywalls V2 button tracking with no purchase, auth, or data-path impact.

Overview
Stops emitting paywall non-purchase componentInteraction events for buttons whose action is a workflow trigger, including the early-return path when the workflow navigator handles the tap.

paywallComponentInteractionValue is now String? and returns nil for .workflowTrigger; trackButtonComponentInteraction() no-ops when there is no value. Other button actions keep the same interaction strings. Diagnostic logging for unknown actions accepts an optional actionValue, and unit tests expect workflow triggers to produce no interaction value.

Reviewed by Cursor Bugbot for commit ba9c992. Bugbot is set up for automated code reviews on this repo. Configure here.

@vegaro vegaro changed the title fix: don't send interaction event for workflow trigger button actions Don't send interaction event for workflow trigger button actions May 12, 2026
@vegaro vegaro marked this pull request as ready for review May 12, 2026 15:40
@vegaro vegaro requested review from a team as code owners May 12, 2026 15:40
vegaro and others added 4 commits May 26, 2026 14:35
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@vegaro vegaro force-pushed the cesar/remove-workflow-trigger-event branch from 4484f9b to 8c6b554 Compare May 27, 2026 00:35
@vegaro

vegaro commented May 27, 2026

Copy link
Copy Markdown
Member Author

@facumenzella can you take a look?

Comment thread Package.resolved Outdated
Comment thread RevenueCatUI/Templates/V2/Components/Button/ButtonComponentView.swift Outdated
@vegaro vegaro enabled auto-merge (squash) May 27, 2026 21:25
@vegaro vegaro disabled auto-merge May 27, 2026 22:33
@vegaro vegaro requested a review from facumenzella May 27, 2026 22:42
@facumenzella

Copy link
Copy Markdown
Member

I'll merge this now @vegaro

@facumenzella facumenzella merged commit 5036d92 into main May 29, 2026
18 of 20 checks passed
@facumenzella facumenzella deleted the cesar/remove-workflow-trigger-event branch May 29, 2026 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants