[Billing Plans]: Introduce Xcode 26.5 build job + handle StoreKitError.paymentMethodBindingConfigurationRequired#6767
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a806a52340
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a806a52. Configure here.
ajpallares
left a comment
There was a problem hiding this comment.
Makes sense! And good idea about at least building for Xcode 26.5 👌
tonidero
left a comment
There was a problem hiding this comment.
I think this makes sense! Just a small comment
| destination: scan-test-output-ios-26 | ||
| - slack-notify-on-fail | ||
|
|
||
| build-xcode-265: |
There was a problem hiding this comment.
Should we add a comment on this one and the reason why we're not running tests? Just so we don't forget.
Motivation
Support for billing plans requires APIs that were shipped in Xcode 26.5. However, we can't run tests on Xcode/iOS 26.5 because of a StoreKit bug where fetching products doesn't work in tests on those versions.
The least we can do is build the SDK using those Xcode/iOS versions to confirm that the SDK compiles there :)
Description
StoreKitError.paymentMethodBindingConfigurationRequiredNote
It looks like the
installation-tests-all-but-carthagejob is failing in CI, but it's also failing in main right now, so it's unrelated to these changes.Note
Medium Risk
Medium risk: changes CI gating by adding a new required job, which can block merges if the Xcode 26.5 environment is unstable; runtime behavior changes only for a newly introduced StoreKit error case and is compiler-gated.
Overview
Adds a new CircleCI
build-xcode-265job that builds (but does not run tests) with Xcode 26.5 across key schemes, and makes it part of the PR and release workflow gates (including on-demand job generation).Updates StoreKit error handling to recognize the new
paymentMethodBindingConfigurationRequiredcase (compiler-gated for Xcode 26.5+) and map it to a store-problem error plus a dedicated tracking string.Reviewed by Cursor Bugbot for commit b0fdb3e. Bugbot is set up for automated code reviews on this repo. Configure here.